Merge lp:~cjwatson/launchpad/snap-build-send-private into lp:launchpad
Proposed by
Colin Watson
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 18903 | ||||
Proposed branch: | lp:~cjwatson/launchpad/snap-build-send-private | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
79 lines (+16/-0) 2 files modified
lib/lp/snappy/model/snapbuildbehaviour.py (+1/-0) lib/lp/snappy/tests/test_snapbuildbehaviour.py (+15/-0) |
||||
To merge this branch: | bzr merge lp:~cjwatson/launchpad/snap-build-send-private | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+364067@code.launchpad.net |
Commit message
Send "private": True to launchpad-buildd for builds of private snaps.
Description of the change
Before we can do anything else with private snap builds, we need to ensure that launchpad-buildd doesn't leak information via SNAPCRAFT_
To post a comment you must log in.
I agree launchpad-buildd should know whether a build is private, but I don't think it maps directly to SNAPCRAFT_ BUILD_INFO. e.g. a normal security build should include SNAPCRAFT_ BUILD_INFO, just without creds.