Merge lp:~cjwatson/launchpad/show-failed-copies into lp:launchpad
Status: | Merged |
---|---|
Approved by: | j.c.sackett |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15620 |
Proposed branch: | lp:~cjwatson/launchpad/show-failed-copies |
Merge into: | lp:launchpad |
Diff against target: |
160 lines (+47/-9) 3 files modified
lib/lp/soyuz/interfaces/packagecopyjob.py (+6/-0) lib/lp/soyuz/model/packagecopyjob.py (+25/-3) lib/lp/soyuz/tests/test_packagecopyjob.py (+16/-6) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/show-failed-copies |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
j.c.sackett (community) | Approve | ||
Review via email: mp+114589@code.launchpad.net |
Commit message
If copying to a PPA, turn copy failures into job failures so that they can show up in the UI, and send failure mail to the requester.
Description of the change
== Summary ==
Bug 812869: PCJs can't be used to copy to PPAs, because the failure mode is uninformative. See also bug 575450.
== Proposed fix ==
Raphaël Badin fixed most of this in r14665, by showing job notifications on Archive:+packages. The unit tests for this manually construct failed jobs. However, this doesn't quite work in practice because, as Julian points out: "This is in part due to the code in PCJ.run() that captures CannotCopy exceptions and swallows them (it assumes that all failures have a DistroSeriesDif
While we're here, we might as well hook up the job runner facility to send an e-mail to the requester on failure.
== LOC Rationale ==
+38. This is part of allowing us to remove synchronous copying from the PPA UI, and later to remove delayed copies, worth at least 1100 lines.
== Tests ==
bin/test -vvct test_packagecopyjob
== Demo and Q/A ==
Somewhat like https:/
This looks alright. Thanks.