Merge lp:~cjwatson/launchpad/remove-single-custom-upload-exception into lp:launchpad
Status: | Merged |
---|---|
Approved by: | William Grant |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15501 |
Proposed branch: | lp:~cjwatson/launchpad/remove-single-custom-upload-exception |
Merge into: | lp:launchpad |
Diff against target: |
60 lines (+18/-18) 2 files modified
lib/lp/archiveuploader/nascentupload.py (+10/-15) lib/lp/archiveuploader/tests/test_ppauploadprocessor.py (+8/-3) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/remove-single-custom-upload-exception |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+112093@code.launchpad.net |
Commit message
Remove "single custom upload" hack: it was profoundly evil and is no longer used.
Description of the change
There is an ancient squamous horror lurking at the heart of archiveuploader: uploads that consist of a single custom file bypass the upload policy checks and thus may entirely lack a source package. Aside from being profoundly bad and wrong, this makes it impossible to do various useful things with these uploads, such as copy them around between pockets.
The only use of this was for translated package descriptions, and Michael Vogt has now amended his scripts to produce a proper source package instead. We should therefore close this loophole before some enterprising soul finds a new use for it.