Merge lp:~cjwatson/launchpad/remove-ppa-builder-limits into lp:launchpad
Status: | Merged |
---|---|
Approved by: | William Grant |
Approved revision: | no longer in the source branch. |
Merged at revision: | 16758 |
Proposed branch: | lp:~cjwatson/launchpad/remove-ppa-builder-limits |
Merge into: | lp:launchpad |
Diff against target: |
120 lines (+9/-61) 2 files modified
lib/lp/buildmaster/tests/test_builder.py (+7/-17) lib/lp/soyuz/model/buildpackagejob.py (+2/-44) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/remove-ppa-builder-limits |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+183834@code.launchpad.net |
Commit message
Remove 80%-of-builders limitation on builds for any given public PPA and architecture.
Description of the change
== Summary ==
Bug 666308 reports unnecessary limitations on certain types of PPAs, as well as a request for more flexibility.
== Proposed fix ==
This is an RFC, but my position is that the limitation on how many builders a given PPA may use at any one time does more harm than good at this point. Now that we have reasonably reliable build cancellation, in the rare cases of abuse or needing something to jump the queue we can always cancel something and retry it later. Other than that, all that this limitation really achieves at this point is to require us to occasionally play silly games with builders' architectures to circumvent it.
We could add more complexity to make this controllable per-PPA or per-owner, as the bug suggests, but I don't think it's worth it.
== Tests ==
bin/test -vvct buildmaster -t soyuz
== Demo and Q/A ==
I don't think we can currently QA this on dogfood since it only has a single working PPA builder at the moment; but since this is pretty much just deleting code I'm not too worried.