Merge lp:~cjwatson/launchpad/queue-copy-archive-links into lp:launchpad
Status: | Merged |
---|---|
Approved by: | William Grant |
Approved revision: | no longer in the source branch. |
Merged at revision: | 16570 |
Proposed branch: | lp:~cjwatson/launchpad/queue-copy-archive-links |
Merge into: | lp:launchpad |
Diff against target: |
452 lines (+152/-38) 14 files modified
lib/lp/_schema_circular_imports.py (+1/-0) lib/lp/app/browser/configure.zcml (+3/-6) lib/lp/app/browser/tales.py (+28/-6) lib/lp/app/doc/tales.txt (+29/-2) lib/lp/soyuz/browser/queue.py (+7/-3) lib/lp/soyuz/browser/tests/test_queue.py (+26/-2) lib/lp/soyuz/configure.zcml (+1/-0) lib/lp/soyuz/interfaces/queue.py (+8/-0) lib/lp/soyuz/model/queue.py (+8/-0) lib/lp/soyuz/templates/build-index.pt (+1/-8) lib/lp/soyuz/templates/distroseries-queue.pt (+7/-7) lib/lp/soyuz/tests/test_packageupload.py (+25/-0) lib/lp/testing/factory.py (+3/-2) lib/lp/testing/tests/test_factory.py (+5/-2) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/queue-copy-archive-links |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+159250@code.launchpad.net |
Commit message
Show link to source archive for copies from PPAs in DistroSeries:
Description of the change
== Summary ==
When reviewing copies in DistroSeries:
== Proposed fix ==
Linkify the archive displayname, at least for PPAs (archive URLs aren't very useful for primary archives). Add an exported copy_source_archive property to PackageUpload. Between them, these changes will make it easier to track things down by hand and should make it possible to teach our "queue" script to follow the breadcrumb trail automatically.
== LOC Rationale ==
+78. I think this is worth it to eliminate a barrier to review for ~ubuntu-release, particularly in the run-up to 13.04 release; and I should have lots of credit from past changes.
== Tests ==
bin/test -vvct lp.soyuz.
== Demo and Q/A ==
Copy a package to a frozen series from (a) Debian and (b) a PPA on dogfood, if there isn't one of each available already. Run the PCJ processor. Check that both render reasonably in the DistroSeries:+queue UI, and that the copy_source_archive property in the API is correct.
Did you consider just using fmt:link for the archive? It's probably not worth special casing PPAs, as non-primary archives have informative URLs that at worst just redirect to the distribution, still making the origin clearer.