Merge lp:~cjwatson/launchpad/queue-api-custom-files into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | j.c.sackett | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 15571 | ||||
Proposed branch: | lp:~cjwatson/launchpad/queue-api-custom-files | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
111 lines (+57/-14) 2 files modified
lib/lp/soyuz/model/queue.py (+7/-1) lib/lp/soyuz/tests/test_packageupload.py (+50/-13) |
||||
To merge this branch: | bzr merge lp:~cjwatson/launchpad/queue-api-custom-files | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
j.c.sackett (community) | Approve | ||
Review via email: mp+113574@code.launchpad.net |
Commit message
Add details of custom uploads to PackageUpload.
Description of the change
== Summary ==
Fix a slight flaw in https:/
== Proposed fix ==
I considered changing customFileUrls to customFiles and adding metadata there, but on reflection that is not ideal because the queue API client would have to add a call to customFiles for every build upload in the queue. A lighter-weight approach is to add custom file properties to getBinaryProperties (the separation between binaries and custom files is in some ways a bit artificial anyway), so the client just gets back a dict with some different keys.
Since there are no production clients for this yet, this slight interface change should be fine.
== LOC Rationale ==
+43, but I'm still comfortably within the limit for this whole arc of work as described in https:/
== Tests ==
bin/test -vvct TestPackageUplo
== Demo and Q/A ==
As with https:/
This looks good, thanks.