Merge lp:~cjwatson/launchpad/product-factory-projectgroup into lp:launchpad

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: no longer in the source branch.
Merged at revision: 17325
Proposed branch: lp:~cjwatson/launchpad/product-factory-projectgroup
Merge into: lp:launchpad
Diff against target: 34 lines (+3/-3)
2 files modified
lib/lp/registry/browser/tests/test_subscription_links.py (+1/-1)
lib/lp/registry/tests/test_projectgroup.py (+2/-2)
To merge this branch: bzr merge lp:~cjwatson/launchpad/product-factory-projectgroup
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+247997@code.launchpad.net

Commit message

Revert premature uses of Product.projectgroup.

Description of the change

I didn't quite pick apart my megabranch correctly, and the previous merge included a couple of premature uses of Product.projectgroup.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/registry/browser/tests/test_subscription_links.py'
2--- lib/lp/registry/browser/tests/test_subscription_links.py 2015-01-29 14:14:01 +0000
3+++ lib/lp/registry/browser/tests/test_subscription_links.py 2015-01-29 15:36:05 +0000
4@@ -453,7 +453,7 @@
5 # parent has a bugtracker (see bug 770287).
6 projectgroup = self.factory.makeProject()
7 with person_logged_in(self.target.owner):
8- self.target.projectgroup = projectgroup
9+ self.target.project = projectgroup
10 self.factory.makeProduct(
11 projectgroup=projectgroup, official_malone=True)
12 self._create_scenario(self.regular_user)
13
14=== modified file 'lib/lp/registry/tests/test_projectgroup.py'
15--- lib/lp/registry/tests/test_projectgroup.py 2015-01-29 14:14:01 +0000
16+++ lib/lp/registry/tests/test_projectgroup.py 2015-01-29 15:36:05 +0000
17@@ -111,7 +111,7 @@
18 name="zazzle-product",
19 title="Hoozah",
20 owner=self.person)
21- product.projectgroup = self.projectgroup1
22+ product.project = self.projectgroup1
23 results = self.projectgroupset.search(
24 text="Hoozah", search_products=False)
25 self.assertEqual(0, results.count())
26@@ -123,7 +123,7 @@
27 name="zazzle-product",
28 title="Hoozah",
29 owner=self.person)
30- product.projectgroup = self.projectgroup1
31+ product.project = self.projectgroup1
32 results = self.projectgroupset.search(
33 text="Hoozah", search_products=True)
34 self.assertEqual(1, results.count())