Merge lp:~cjwatson/launchpad/new-person-edit-timezone into lp:launchpad
Proposed by
Colin Watson
Status: | Merged |
---|---|
Merged at revision: | 18126 |
Proposed branch: | lp:~cjwatson/launchpad/new-person-edit-timezone |
Merge into: | lp:launchpad |
Diff against target: |
221 lines (+26/-29) 10 files modified
lib/lp/app/browser/tales.py (+2/-4) lib/lp/app/doc/tales.txt (+4/-1) lib/lp/app/widgets/date.py (+3/-4) lib/lp/registry/browser/person.py (+4/-9) lib/lp/registry/model/person.py (+2/-2) lib/lp/registry/stories/location/personlocation-edit.txt (+4/-2) lib/lp/registry/stories/webservice/xx-person.txt (+2/-2) lib/lp/registry/stories/webservice/xx-personlocation.txt (+2/-2) lib/lp/registry/templates/person-portlet-contact-details.pt (+1/-1) lib/lp/services/webapp/launchbag.py (+2/-2) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/new-person-edit-timezone |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Thomi Richards (community) | Approve | ||
Launchpad code reviewers | Pending | ||
Review via email: mp+293188@code.launchpad.net |
Commit message
Make Person.time_zone always be non-None, allowing us to easily show the edit widget even for users who have never set their time zone.
Description of the change
Make Person.time_zone always be non-None, allowing us to easily show the edit widget even for users who have never set their time zone.
Fixing bug 933699 would also be a valid approach to this, but that's rather more work, and I think it makes sense in any event for the Person.time_zone property to deal with picking a reasonable default rather than callers having to do so.
To post a comment you must log in.