Code review comment for lp:~cjwatson/launchpad/multiarch-translations

Revision history for this message
Colin Watson (cjwatson) wrote :

comments.sql change done. Per a conversation with William, I renamed
the column to include_long_descriptions (as I'd got the sense of the
underlying apt.conf variable wrong, and wanted to keep the boolean
values the same way round), and adjusted the description accordingly; I
hope that doesn't invalidate the DB review.

For William: I checked with Michael Vogt, and apparently apt will fetch
Translation-en files in the LANG=C case, so I don't think we need to
worry about Translation-C files.

I also noticed that apt-ftparchive won't create the i18n directories
itself, so I added a conditional safe_mkdir call to

I've asked Michael to prepare an apt backport with sufficient
LongDescription support, as lucid-updates doesn't have everything we

« Back to merge proposal