Merge lp:~cjwatson/launchpad/mp-revision-id-text-line into lp:launchpad

Proposed by Colin Watson
Status: Merged
Merged at revision: 18442
Proposed branch: lp:~cjwatson/launchpad/mp-revision-id-text-line
Merge into: lp:launchpad
Diff against target: 30 lines (+3/-3)
1 file modified
lib/lp/code/interfaces/branchmergeproposal.py (+3/-3)
To merge this branch: bzr merge lp:~cjwatson/launchpad/mp-revision-id-text-line
Reviewer Review Type Date Requested Status
William Grant code Approve
Review via email: mp+328082@code.launchpad.net

Commit message

Declare revision IDs as TextLine, not Text.

Description of the change

This should hopefully stop revision IDs being rendered using enormous text boxes in forms, e.g. on BranchMergeProposal:+merged.

To post a comment you must log in.
Revision history for this message
William Grant (wgrant) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/code/interfaces/branchmergeproposal.py'
2--- lib/lp/code/interfaces/branchmergeproposal.py 2016-06-25 08:07:19 +0000
3+++ lib/lp/code/interfaces/branchmergeproposal.py 2017-07-26 11:45:31 +0000
4@@ -277,7 +277,7 @@
5 'target branch.'), readonly=True))
6
7 reviewed_revision_id = exported(
8- Text(
9+ TextLine(
10 title=_(
11 "The revision id that has been approved by the reviewer.")),
12 exported_as='reviewed_revid')
13@@ -298,7 +298,7 @@
14 "merge from the source branch (Bazaar only).")))
15
16 merged_revision_id = exported(
17- Text(
18+ TextLine(
19 title=_("Merged Revision ID"), required=False, readonly=True,
20 description=_(
21 "The revision ID on the target branch which contains the "
22@@ -516,7 +516,7 @@
23 status=Choice(
24 title=_("The new status of the merge proposal."),
25 vocabulary=BranchMergeProposalStatus),
26- revision_id=Text(
27+ revision_id=TextLine(
28 description=_("An optional parameter for specifying the "
29 "revision of the branch for the status change."),
30 required=False))