Merge lp:~cjwatson/launchpad/more-robust-debdiff-timeout into lp:launchpad
Proposed by
Colin Watson
Status: | Merged |
---|---|
Merged at revision: | 19000 |
Proposed branch: | lp:~cjwatson/launchpad/more-robust-debdiff-timeout |
Merge into: | lp:launchpad |
Diff against target: |
75 lines (+11/-10) 2 files modified
lib/lp/soyuz/model/packagediff.py (+7/-9) lib/lp/soyuz/tests/test_packagediff.py (+4/-1) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/more-robust-debdiff-timeout |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+369535@code.launchpad.net |
Commit message
Use timeout(1) to limit debdiff rather than using alarm(3) ourselves.
Description of the change
The approach of calling alarm(3) and then execing the target command relies on the target command not changing the disposition of SIGALRM, and may have other problems (we've observed PackageDiffJobs occasionally hanging indefinitely, although we don't know exactly why that's happening). coreutils has a perfectly good timeout(1) program that we can use instead, which runs the target command as a child process and in general seems likely to be more robust.
To post a comment you must log in.