Merge lp:~cjwatson/launchpad/livefs-garbo into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | William Grant | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 17056 | ||||
Proposed branch: | lp:~cjwatson/launchpad/livefs-garbo | ||||
Merge into: | lp:launchpad | ||||
Prerequisite: | lp:~cjwatson/launchpad/livefs | ||||
Diff against target: |
145 lines (+69/-4) 2 files modified
lib/lp/scripts/garbo.py (+25/-1) lib/lp/scripts/tests/test_garbo.py (+44/-3) |
||||
To merge this branch: | bzr merge lp:~cjwatson/launchpad/livefs-garbo | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+217784@code.launchpad.net |
Commit message
Add a garbo job to remove old LiveFSFile records.
Description of the change
== Summary ==
Next stage of bug 1247461, following https:/
== Proposed fix ==
I explored various options including keeping the current image for each LiveFS, but that turned out to be cumbersome to get right: we'd have had to do something special to avoid images eventually piling up for old series that we don't build for any more. In the end I decided to keep it simple for now: remove any images more than a day old, which will be more than enough time for cdimage to fetch them and build ISOs out of them or publish them somewhere persistent. We can always tweak this later.
This will require cdimage to use its locally-cached copy if somebody tries to do an image build that intentionally doesn't rebuild the livefs. But the rearrangements for this will be a good thing anyway: in particular they will arrange that we don't do an image build if the corresponding livefs build failed, which has been a long-standing problem in cdimage that causes confusion from time to time (at present we only fail the image build if livefs builds on all architectures fail, and otherwise carry on merrily using an old livefs on some architectures).
== LOC Rationale ==
+65; same rationale as https:/
== Tests ==
bin/test -vvct LiveFSFilePruner
== Demo and Q/A ==
Build an image, wait a day (or hack the DB to lie about its date_finished), run garbo, and check that the appropriate LiveFSBuild's binary LiveFSFile artifacts are pruned.