Merge lp:~cjwatson/launchpad/isolate-gpgme into lp:launchpad
Proposed by
Colin Watson
Status: | Rejected |
---|---|
Rejected by: | Colin Watson |
Proposed branch: | lp:~cjwatson/launchpad/isolate-gpgme |
Merge into: | lp:launchpad |
Diff against target: |
197 lines (+60/-17) 2 files modified
lib/lp/services/gpg/handler.py (+54/-14) lib/lp/testing/gpgkeys/__init__.py (+6/-3) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/isolate-gpgme |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Launchpad code reviewers | Pending | ||
Review via email: mp+310906@code.launchpad.net |
Commit message
Isolate gpgme from its terminal environment, if any.
Description of the change
I've been having problems for ages with spurious gpgme-related test failures in my local environment that went away when I piped the output through cat, and this was particularly annoying any time I needed to apply pdb to one of them. This isolates things so that that isn't a problem any more.
To post a comment you must log in.
Unmerged revisions
- 18270. By Colin Watson
-
Isolate gpgme from its terminal environment, if any.
This seems like a pretty big hammer to use outside the test suite. The appservers are single-threaded today, but it still feels quite off. Have you examined whether we can force a null pinentry with gpg1? IIRC from my gpg2 work it's certainly possible there -- maybe it's worth just living with the problem until we're on xenial.