Merge lp:~cjwatson/launchpad/git-permissions-non-unicode-refs into lp:launchpad
Proposed by
Colin Watson
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 18830 | ||||
Proposed branch: | lp:~cjwatson/launchpad/git-permissions-non-unicode-refs | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
180 lines (+100/-12) 4 files modified
lib/lp/code/interfaces/gitrepository.py (+2/-1) lib/lp/code/model/gitrepository.py (+5/-1) lib/lp/code/xmlrpc/git.py (+24/-5) lib/lp/code/xmlrpc/tests/test_git.py (+69/-5) |
||||
To merge this branch: | bzr merge lp:~cjwatson/launchpad/git-permissions-non-unicode-refs | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tom Wardill (community) | Approve | ||
Launchpad code reviewers | Pending | ||
Review via email: mp+359088@code.launchpad.net |
Commit message
Begin converting GitAPI.
Description of the change
Git ref paths may not be valid UTF-8, so we need to treat them as bytes. We can't deal perfectly with non-UTF-8 refs - they won't get scanned and so won't show up in the webservice API or the web UI - but we can at least allow them to round-trip through Launchpad at the git level. I believe we tested that a while back and it was fine, but then we forgot about it during the permissions work so it regressed.
I have most of a turnip branch to deal with the other end of this, but the webapp needs to support it first.
To post a comment you must log in.