Merge lp:~cjwatson/launchpad/git-pending-merges-preload-messages into lp:launchpad
Proposed by
Colin Watson
Status: | Merged |
---|---|
Merged at revision: | 18773 |
Proposed branch: | lp:~cjwatson/launchpad/git-pending-merges-preload-messages |
Merge into: | lp:launchpad |
Diff against target: |
98 lines (+26/-7) 2 files modified
lib/lp/code/browser/tests/test_gitrepository.py (+15/-2) lib/lp/code/model/branchmergeproposal.py (+11/-5) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/git-pending-merges-preload-messages |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tom Wardill (community) | Approve | ||
Launchpad code reviewers | Pending | ||
Review via email: mp+354622@code.launchpad.net |
Commit message
Preload review comments on merge proposals when preloading votes.
Description of the change
There's still a small number of TeamParticipation queries (up to three) per distinct reviewer; but as far as I can see there's no precedent for preloading these, and it would require some new helpers to do the right thing. IMO this isn't urgent, because the set of all active merge proposals targeted at a given repository will usually have only a small number of distinct reviewers.
To post a comment you must log in.