Created by Colin Watson on 2019-04-15 and last modified on 2019-05-10
Get this branch:
bzr branch lp:~cjwatson/launchpad/git-honour-access-tokens
Only Colin Watson can upload to this branch. If you are Colin Watson please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Colin Watson
Launchpad itself

Recent revisions

18653. By Colin Watson on 2019-05-10

Merge devel.

18652. By Colin Watson on 2019-05-02

Return a uniform Unauthorized fault when verifying a git macaroon fails.

This is more in the keeping of the definition of 401 in RFC 2616, and it
avoids problems with allowing probing for visible repositories even with a
macaroon constrained to a single repository.

18651. By Colin Watson on 2019-05-02

Merge devel.

18650. By Colin Watson on 2019-04-15

Make the Git XML-RPC API honour user macaroons.

18649. By Colin Watson on 2019-04-15

Add a macaroon issuer for Git access tokens.

18648. By Colin Watson on 2019-04-11

Push repository -> job inference down from GitAPI to the macaroon issuer.

I think this makes slightly more logical sense, and it will shortly make it
easier to cope with the case where a different macaroon issuer might be

18647. By Colin Watson on 2019-04-11

Add logging to macaroon verification, and refactor tests to check it.

It was all too easy for macaroon verification to fail for some reason other
than the one that a test expected, and tests had no way to tell. We now log
details of verification failures, and I added a couple of test helpers to
make it easy for tests to check these consistently.

18646. By Colin Watson on 2019-04-11

Make TestCodeImportJobMacaroonIssuer.test_verifyMacaroon_wrong_job useful.

job and other_job were in fact equal due to the odd way that
BareLaunchpadObjectFactory.makeCodeImportJob works, but this mistake was
masked because the job wasn't started and so macaroon verification failed
for that reason.

18645. By Colin Watson on 2019-04-11

Merge snap-build-macaroon.

18644. By Colin Watson on 2019-04-09

Merge snap-build-macaroon.

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
This branch contains Public information 
Everyone can see this information.