Merge lp:~cjwatson/launchpad/fix-packagediff-private into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15627 |
Proposed branch: | lp:~cjwatson/launchpad/fix-packagediff-private |
Merge into: | lp:launchpad |
Diff against target: |
96 lines (+27/-6) 4 files modified
lib/lp/soyuz/doc/package-diff.txt (+1/-1) lib/lp/soyuz/model/packagediff.py (+3/-2) lib/lp/soyuz/tests/soyuz.py (+2/-1) lib/lp/soyuz/tests/test_packagediff.py (+21/-2) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/fix-packagediff-private |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email: mp+114759@code.launchpad.net |
Commit message
Make a PackageDiff public if any of its source's published archives are public.
Description of the change
== Summary ==
Bug 1023986: package diffs for security uploads are sometimes inappropriately private. I think this is because they've been generated against SPRs that were originally uploaded to a private archive, so PackageDiff incorrectly thinks that diffs against them need to be private even though they've since been unembargoed.
== Proposed fix ==
Check privacy of published_archives rather than of upload_archive.
== LOC Rationale ==
+21. I have 1625 lines of credit. Besides, this is probably part of the work to let us remove delayed copies and the ubuntu-security celebrity and suchlike, which should make up for it.
== Tests ==
bin/test -vvct test_packagediff
== Demo and Q/A ==
Upload a package whose ancestry is an SPR that was originally uploaded to a private archive (e.g. a security update) and check that its PackageDiffs are public.
Thanks for the fix Colin