Merge lp:~cjwatson/launchpad/fix-packagediff-private-harder into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15644 |
Proposed branch: | lp:~cjwatson/launchpad/fix-packagediff-private-harder |
Merge into: | lp:launchpad |
Diff against target: |
44 lines (+13/-2) 3 files modified
lib/lp/soyuz/doc/package-diff.txt (+1/-0) lib/lp/soyuz/model/packagediff.py (+3/-2) lib/lp/soyuz/tests/test_packagediff.py (+9/-0) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/fix-packagediff-private-harder |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Richard Harding (community) | Approve | ||
Review via email: mp+115352@code.launchpad.net |
Commit message
Consider SPR.upload_archive as well as SPR.published_
Description of the change
== Summary ==
https:/
== Proposed fix ==
Consider the privacy of the upload archive as well as that of published archives.
== LOC Rationale ==
+10. Same rationale as https:/
== Tests ==
bin/test -vvct test_packagediff
== Demo and Q/A ==
Upload a package to a frozen or stable series on dogfood. Generate the pending package diff for it, then accept it. Check that the package diff is public.