Merge lp:~cjwatson/launchpad/fix-githosting-compare-merge into lp:launchpad
Proposed by
Colin Watson
| Status: | Merged |
|---|---|
| Merged at revision: | 17472 |
| Proposed branch: | lp:~cjwatson/launchpad/fix-githosting-compare-merge |
| Merge into: | lp:launchpad |
| Diff against target: | 0 lines |
| To merge this branch: | bzr merge lp:~cjwatson/launchpad/fix-githosting-compare-merge |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| William Grant | code | Approve | |
|
Review via email:
|
|||
Commit message
Fix GitHostingClient URL construction to avoid mangling colons.
Description of the change
Fix GitHostingClient URL construction to avoid mangling colons.
This is unfortunately untested until such time as we have a turnip fixture, but I've confirmed that these urljoin calls behave sensibly locally. bzrlib.urlutils has bizarre ideas and thinks that "<sha1>:<sha1>" includes a scheme.
To post a comment you must log in.
Revision history for this message
| William Grant (wgrant) | # |
review:
Approve
(code)
