Merge lp:~cjwatson/launchpad/feedparser-5.2.1 into lp:launchpad

Proposed by Colin Watson on 2018-07-16
Status: Merged
Merged at revision: 18732
Proposed branch: lp:~cjwatson/launchpad/feedparser-5.2.1
Merge into: lp:launchpad
Diff against target: 25 lines (+2/-2)
2 files modified
constraints.txt (+1/-1)
setup.py (+1/-1)
To merge this branch: bzr merge lp:~cjwatson/launchpad/feedparser-5.2.1
Reviewer Review Type Date Requested Status
Simon Davy (community) Approve on 2018-07-16
Launchpad code reviewers 2018-07-16 Pending
Review via email: mp+349639@code.launchpad.net

Commit message

Upgrade to feedparser 5.2.1.

Description of the change

This adds Python 3 support. I also want this because the previous version monkey-patched sgmllib, which caused weird problems with BeautifulSoup in some cases; this version no longer does that.

Launchpad only uses feedparser to get the latest entries from blog.launchpad.net for the front page, and I've verified that the results of doing that are identical with the old and new versions.

To post a comment you must log in.
Simon Davy (bloodearnest) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'constraints.txt'
2--- constraints.txt 2018-07-10 09:05:45 +0000
3+++ constraints.txt 2018-07-16 11:13:23 +0000
4@@ -253,7 +253,7 @@
5 enum34==1.1.6
6 epydoc==3.0.1
7 extras==1.0.0
8-feedparser==4.1
9+feedparser==5.2.1
10 feedvalidator==0.0.0DEV-r1049
11 fixtures==3.0.0
12 FormEncode==1.2.4
13
14=== modified file 'setup.py'
15--- setup.py 2018-07-01 21:56:44 +0000
16+++ setup.py 2018-07-16 11:13:23 +0000
17@@ -156,7 +156,7 @@
18 # Required for dkimpy
19 'dnspython',
20 'dulwich',
21- 'FeedParser',
22+ 'feedparser',
23 'feedvalidator',
24 'fixtures',
25 'gunicorn[gthread]',