Merge lp:~cjwatson/launchpad/eslint-remove-unused-vars into lp:launchpad
- eslint-remove-unused-vars
- Merge into devel
Proposed by
Colin Watson
Status: | Merged |
---|---|
Merged at revision: | 18431 |
Proposed branch: | lp:~cjwatson/launchpad/eslint-remove-unused-vars |
Merge into: | lp:launchpad |
Prerequisite: | lp:~cjwatson/launchpad/eslint-remove-dead-code |
Diff against target: |
438 lines (+44/-60) 21 files modified
lib/lp/app/javascript/anim/tests/test_anim.js (+1/-2) lib/lp/app/javascript/gallery-accordion/gallery-accordion.js (+2/-2) lib/lp/app/javascript/picker/tests/test_picker_patcher.js (+1/-1) lib/lp/app/javascript/subscribers/tests/test_subscribers_list.js (+11/-17) lib/lp/app/javascript/tests/test_expander.js (+2/-2) lib/lp/app/javascript/tests/test_foldables.js (+1/-1) lib/lp/app/javascript/tests/test_longpoll.js (+1/-1) lib/lp/bugs/javascript/bugtask_index.js (+8/-8) lib/lp/bugs/javascript/duplicates.js (+1/-2) lib/lp/bugs/javascript/filebug.js (+1/-5) lib/lp/bugs/javascript/tests/test_bug_notification_level.js (+1/-1) lib/lp/bugs/javascript/tests/test_filebug.js (+1/-1) lib/lp/bugs/javascript/tests/test_pre_search.js (+2/-3) lib/lp/bugs/javascript/tests/test_subscription.js (+2/-4) lib/lp/registry/javascript/distroseries/widgets.js (+1/-1) lib/lp/registry/javascript/distroseriesdifferences_details.js (+3/-3) lib/lp/registry/javascript/structural-subscription.js (+1/-1) lib/lp/registry/javascript/tests/test_distroseriesdifferences_details.js (+1/-1) lib/lp/registry/javascript/tests/test_team_mailinglists.js (+1/-2) lib/lp/soyuz/javascript/base.js (+1/-1) lib/lp/testing/tests/test_yuixhr_fixture.js (+1/-1) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/eslint-remove-unused-vars |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | Approve | ||
Review via email: mp+327894@code.launchpad.net |
Commit message
Remove lots of unused variable assignments spotted by ESLint.
Description of the change
To post a comment you must log in.
Revision history for this message
William Grant (wgrant) : | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1 | === modified file 'lib/lp/app/javascript/anim/tests/test_anim.js' |
2 | --- lib/lp/app/javascript/anim/tests/test_anim.js 2013-03-20 03:41:40 +0000 |
3 | +++ lib/lp/app/javascript/anim/tests/test_anim.js 2017-07-21 17:11:32 +0000 |
4 | @@ -52,8 +52,7 @@ |
5 | test_resolveNodeListFrom_anythine_else: function() { |
6 | var succeed = true; |
7 | try { |
8 | - var nodelist = tests.resolveNodeListFrom( |
9 | - {crazy: true, broken: 'definitely'}); |
10 | + tests.resolveNodeListFrom({crazy: true, broken: 'definitely'}); |
11 | } catch(e) { |
12 | succeed = false; |
13 | } |
14 | |
15 | === modified file 'lib/lp/app/javascript/gallery-accordion/gallery-accordion.js' |
16 | --- lib/lp/app/javascript/gallery-accordion/gallery-accordion.js 2011-03-15 13:29:18 +0000 |
17 | +++ lib/lp/app/javascript/gallery-accordion/gallery-accordion.js 2017-07-21 17:11:32 +0000 |
18 | @@ -904,7 +904,7 @@ |
19 | * @param item {Y.AccordionItem} An <code>Y.AccordionItem</code> instance to be set as draggable |
20 | */ |
21 | _initItemDragDrop: function( item ){ |
22 | - var itemHeader, dd, bb, itemBB, ddrop; |
23 | + var itemHeader, dd, bb, itemBB; |
24 | |
25 | itemHeader = item.getStdModNode( WidgetStdMod.HEADER ); |
26 | |
27 | @@ -924,7 +924,7 @@ |
28 | constrain2node: bb |
29 | }); |
30 | |
31 | - ddrop = new Y.DD.Drop({ |
32 | + new Y.DD.Drop({ |
33 | node: itemBB, |
34 | groups: [ DRAGGROUP ] |
35 | }); |
36 | |
37 | === modified file 'lib/lp/app/javascript/picker/tests/test_picker_patcher.js' |
38 | --- lib/lp/app/javascript/picker/tests/test_picker_patcher.js 2016-09-12 19:41:46 +0000 |
39 | +++ lib/lp/app/javascript/picker/tests/test_picker_patcher.js 2017-07-21 17:11:32 +0000 |
40 | @@ -352,7 +352,7 @@ |
41 | // to copy the selected value to the text input field. |
42 | this.text_input = Y.Node.create( |
43 | '<input id="field.testfield" value="foo" />'); |
44 | - var node = Y.one(document.body).appendChild(this.text_input); |
45 | + Y.one(document.body).appendChild(this.text_input); |
46 | this.select_menu = Y.Node.create( |
47 | '<select id="field.testfield-suggestions"> ' + |
48 | ' <option value="">Did you mean...</option>' + |
49 | |
50 | === modified file 'lib/lp/app/javascript/subscribers/tests/test_subscribers_list.js' |
51 | --- lib/lp/app/javascript/subscribers/tests/test_subscribers_list.js 2017-07-21 17:11:31 +0000 |
52 | +++ lib/lp/app/javascript/subscribers/tests/test_subscribers_list.js 2017-07-21 17:11:32 +0000 |
53 | @@ -110,7 +110,7 @@ |
54 | test_no_container_error: function() { |
55 | // When there is no matching container node in the DOM tree, |
56 | // an exception is thrown. |
57 | - var sl = new module.SubscribersList({ |
58 | + new module.SubscribersList({ |
59 | container_box: '#not-found', |
60 | subscriber_levels: []}); |
61 | }, |
62 | @@ -133,7 +133,7 @@ |
63 | Y.Node.create('<div />').addClass('container')); |
64 | this.root.appendChild( |
65 | Y.Node.create('<div />').addClass('container')); |
66 | - var sl = new module.SubscribersList({ |
67 | + new module.SubscribersList({ |
68 | container_box: '.container', |
69 | subscriber_levels: []}); |
70 | }, |
71 | @@ -761,7 +761,7 @@ |
72 | test_removeSectionNodeIfEmpty_keeps_others: function() { |
73 | // With two empty sections, only the requested one is removed. |
74 | var subscribers_list = setUpSubscribersList(this.root); |
75 | - var section_node1 = subscribers_list._getOrCreateSection('Level3'); |
76 | + subscribers_list._getOrCreateSection('Level3'); |
77 | var section_node2 = subscribers_list._getOrCreateSection( |
78 | 'Level1'); |
79 | |
80 | @@ -1187,8 +1187,7 @@ |
81 | // fails with an exception. |
82 | var subscribers_list = setUpSubscribersList(this.root); |
83 | var subscriber = { name: 'user' }; |
84 | - var subscriber_node = subscribers_list.addSubscriber( |
85 | - subscriber, 'Level1'); |
86 | + subscribers_list.addSubscriber(subscriber, 'Level1'); |
87 | subscribers_list.addUnsubscribeAction(subscriber, "not-function"); |
88 | }, |
89 | |
90 | @@ -1224,9 +1223,7 @@ |
91 | // Removing a subscriber works when the subscriber is in the list. |
92 | var subscribers_list = setUpSubscribersList(this.root); |
93 | var subscriber = { name: 'user' }; |
94 | - var subscriber_node = subscribers_list.addSubscriber( |
95 | - subscriber, 'Level3'); |
96 | - var section_node = subscriber_node.ancestor('.subscribers-section'); |
97 | + subscribers_list.addSubscriber(subscriber, 'Level3'); |
98 | subscribers_list.removeSubscriber(subscriber); |
99 | // Entire section is removed along with the subscriber. |
100 | Y.Assert.areEqual(0, _getAllSections(subscribers_list).length); |
101 | @@ -1238,9 +1235,7 @@ |
102 | var subscriber = { name: 'user' }; |
103 | var other_node = subscribers_list.addSubscriber( |
104 | { name: 'other' }, 'Level3'); |
105 | - var subscriber_node = subscribers_list.addSubscriber( |
106 | - subscriber, 'Level3'); |
107 | - var section_node = subscriber_node.ancestor('.subscribers-section'); |
108 | + subscribers_list.addSubscriber(subscriber, 'Level3'); |
109 | subscribers_list.removeSubscriber(subscriber); |
110 | // Section is not removed because it still has 'other' subscriber. |
111 | var all_sections = _getAllSections(subscribers_list); |
112 | @@ -1341,7 +1336,7 @@ |
113 | // When there's no activity in progress, nothing happens. |
114 | var subscribers_list = setUpSubscribersList(this.root); |
115 | var subscriber = { name: 'user' }; |
116 | - var node = subscribers_list.addSubscriber(subscriber, 'Level3'); |
117 | + subscribers_list.addSubscriber(subscriber, 'Level3'); |
118 | subscribers_list.stopSubscriberActivity(subscriber); |
119 | }, |
120 | |
121 | @@ -1454,10 +1449,9 @@ |
122 | test_SubscribersLoader_container_error: function() { |
123 | // If no container node to hold the subscribers list is specified, |
124 | // it fails with an error. |
125 | - var loader = |
126 | - new module.SubscribersLoader({ |
127 | - container_box: '#not-found', |
128 | - subscriber_levels: []}); |
129 | + new module.SubscribersLoader({ |
130 | + container_box: '#not-found', |
131 | + subscriber_levels: []}); |
132 | }, |
133 | |
134 | test_SubscribersLoader_context_error: function() { |
135 | @@ -1999,7 +1993,7 @@ |
136 | setup_called = true; |
137 | }; |
138 | |
139 | - var loader = setUpLoader(this.root, config); |
140 | + setUpLoader(this.root, config); |
141 | |
142 | Y.Assert.isTrue(setup_called); |
143 | |
144 | |
145 | === modified file 'lib/lp/app/javascript/tests/test_expander.js' |
146 | --- lib/lp/app/javascript/tests/test_expander.js 2014-01-24 04:41:21 +0000 |
147 | +++ lib/lp/app/javascript/tests/test_expander.js 2017-07-21 17:11:32 +0000 |
148 | @@ -61,7 +61,7 @@ |
149 | } |
150 | var root = this.makeNode(); |
151 | var hook = root.appendChild(this.makeNode('hook')); |
152 | - var icon = hook.appendChild(this.makeNode('icon')); |
153 | + hook.appendChild(this.makeNode('icon')); |
154 | var content = hook.appendChild(this.makeNode('content')); |
155 | if (args.expanded) { |
156 | content.addClass('expanded'); |
157 | @@ -149,7 +149,7 @@ |
158 | var root = this.makeExpanderHooks(); |
159 | var icon = root.one('.icon'); |
160 | icon.addClass('hidden'); |
161 | - var expander = this.makeExpander(root); |
162 | + this.makeExpander(root); |
163 | Y.Assert.isFalse(icon.hasClass('hidden')); |
164 | }, |
165 | |
166 | |
167 | === modified file 'lib/lp/app/javascript/tests/test_foldables.js' |
168 | --- lib/lp/app/javascript/tests/test_foldables.js 2013-03-20 03:41:40 +0000 |
169 | +++ lib/lp/app/javascript/tests/test_foldables.js 2017-07-21 17:11:32 +0000 |
170 | @@ -101,7 +101,7 @@ |
171 | |
172 | var link = Y.one('a'); |
173 | link.simulate('click'); |
174 | - var quote = Y.one('.foldable-quoted'); |
175 | + quote = Y.one('.foldable-quoted'); |
176 | Y.Assert.areSame(quote.getStyle('display'), 'inline'); |
177 | |
178 | // Make sure that if clicked again it hides. |
179 | |
180 | === modified file 'lib/lp/app/javascript/tests/test_longpoll.js' |
181 | --- lib/lp/app/javascript/tests/test_longpoll.js 2017-07-21 17:11:31 +0000 |
182 | +++ lib/lp/app/javascript/tests/test_longpoll.js 2017-07-21 17:11:32 +0000 |
183 | @@ -94,7 +94,7 @@ |
184 | Y.on(longpoll.longpoll_start_event, function() { |
185 | fired = true; |
186 | }); |
187 | - var manager = this.setupLongPoll(); |
188 | + this.setupLongPoll(); |
189 | Y.Assert.isTrue(fired, "Start event not fired."); |
190 | }, |
191 | |
192 | |
193 | === modified file 'lib/lp/bugs/javascript/bugtask_index.js' |
194 | --- lib/lp/bugs/javascript/bugtask_index.js 2017-07-21 17:11:31 +0000 |
195 | +++ lib/lp/bugs/javascript/bugtask_index.js 2017-07-21 17:11:32 +0000 |
196 | @@ -545,13 +545,13 @@ |
197 | (LP.links.me !== null)) { |
198 | if (Y.Lang.isValue(bugtarget_content)) { |
199 | if (conf.target_is_product) { |
200 | - var bugtarget_picker = Y.lp.app.picker.addPickerPatcher( |
201 | - 'Product', |
202 | - conf.bugtask_path, |
203 | - "target_link", |
204 | - bugtarget_content.get('id'), |
205 | - {"step_title": "Search projects", |
206 | - "header": "Change project"}); |
207 | + Y.lp.app.picker.addPickerPatcher( |
208 | + 'Product', |
209 | + conf.bugtask_path, |
210 | + "target_link", |
211 | + bugtarget_content.get('id'), |
212 | + {"step_title": "Search projects", |
213 | + "header": "Change project"}); |
214 | } |
215 | } |
216 | |
217 | @@ -1046,7 +1046,7 @@ |
218 | if (!Y.Lang.isValue(io_provider)) { |
219 | io_provider = Y.lp.client.get_configured_io_provider(); |
220 | } |
221 | - var request = io_provider.io(batched_comments_url, {on: handlers}); |
222 | + io_provider.io(batched_comments_url, {on: handlers}); |
223 | }; |
224 | |
225 | /** |
226 | |
227 | === modified file 'lib/lp/bugs/javascript/duplicates.js' |
228 | --- lib/lp/bugs/javascript/duplicates.js 2017-07-21 17:11:31 +0000 |
229 | +++ lib/lp/bugs/javascript/duplicates.js 2017-07-21 17:11:32 +0000 |
230 | @@ -339,7 +339,6 @@ |
231 | } |
232 | |
233 | var that = this; |
234 | - var spinner = null; |
235 | var error_handler = this._error_handler(widget); |
236 | var submit_url = LP.cache.context.web_link + '/+duplicate'; |
237 | var y_config = { |
238 | @@ -362,7 +361,7 @@ |
239 | } |
240 | } |
241 | that.set('error', null); |
242 | - spinner = that._show_bug_spinner(widget); |
243 | + that._show_bug_spinner(widget); |
244 | }, |
245 | success: function(id, response) { |
246 | that._submit_bug_success( |
247 | |
248 | === modified file 'lib/lp/bugs/javascript/filebug.js' |
249 | --- lib/lp/bugs/javascript/filebug.js 2014-01-30 15:04:06 +0000 |
250 | +++ lib/lp/bugs/javascript/filebug.js 2017-07-21 17:11:32 +0000 |
251 | @@ -11,11 +11,7 @@ |
252 | var namespace = Y.namespace('lp.bugs.filebug'); |
253 | var info_type = Y.lp.app.information_type; |
254 | |
255 | -// For tests. |
256 | -var skip_animation; |
257 | - |
258 | -var setup_filebug = function(skip_anim) { |
259 | - skip_animation = skip_anim; |
260 | +var setup_filebug = function() { |
261 | if (LP.cache.enable_bugfiling_duplicate_search) { |
262 | Y.lp.bugs.filebug_dupefinder.setup_dupe_finder(); |
263 | } |
264 | |
265 | === modified file 'lib/lp/bugs/javascript/tests/test_bug_notification_level.js' |
266 | --- lib/lp/bugs/javascript/tests/test_bug_notification_level.js 2013-03-20 03:41:40 +0000 |
267 | +++ lib/lp/bugs/javascript/tests/test_bug_notification_level.js 2017-07-21 17:11:32 +0000 |
268 | @@ -216,7 +216,7 @@ |
269 | var radio_buttons = node.all('input[name="field.subscription"]'); |
270 | |
271 | module._bug_notification_level_visible = false; |
272 | - var state = module._initialize(radio_buttons, level_node); |
273 | + module._initialize(radio_buttons, level_node); |
274 | Y.Assert.isTrue(module._bug_notification_level_visible); |
275 | }, |
276 | |
277 | |
278 | === modified file 'lib/lp/bugs/javascript/tests/test_filebug.js' |
279 | --- lib/lp/bugs/javascript/tests/test_filebug.js 2013-03-20 03:41:40 +0000 |
280 | +++ lib/lp/bugs/javascript/tests/test_filebug.js 2017-07-21 17:11:32 +0000 |
281 | @@ -57,7 +57,7 @@ |
282 | } |
283 | var form = Y.Node.create(Y.one('#' + form_id).getContent()); |
284 | this.fixture.appendChild(form); |
285 | - Y.lp.bugs.filebug.setup_filebug(true); |
286 | + Y.lp.bugs.filebug.setup_filebug(); |
287 | }, |
288 | |
289 | tearDown: function () { |
290 | |
291 | === modified file 'lib/lp/bugs/javascript/tests/test_pre_search.js' |
292 | --- lib/lp/bugs/javascript/tests/test_pre_search.js 2013-03-20 03:41:40 +0000 |
293 | +++ lib/lp/bugs/javascript/tests/test_pre_search.js 2017-07-21 17:11:32 +0000 |
294 | @@ -3,9 +3,8 @@ |
295 | |
296 | YUI.add('lp.bugs.bugtask_index.test_pre_search', function (Y) { |
297 | var module = Y.lp.bugs.bugtask_index; |
298 | - // Local aliases |
299 | - var Assert = Y.Assert, |
300 | - ArrayAssert = Y.ArrayAssert; |
301 | + // Local alias. |
302 | + var ArrayAssert = Y.ArrayAssert; |
303 | |
304 | // A picker implementation that records method calls for testing. |
305 | function FauxPicker() { |
306 | |
307 | === modified file 'lib/lp/bugs/javascript/tests/test_subscription.js' |
308 | --- lib/lp/bugs/javascript/tests/test_subscription.js 2017-07-21 17:11:31 +0000 |
309 | +++ lib/lp/bugs/javascript/tests/test_subscription.js 2017-07-21 17:11:32 +0000 |
310 | @@ -2200,8 +2200,7 @@ |
311 | var args = { bugs: [ { self: { self_link: 'http://bug/' } } ], |
312 | teams: [ { self: { self_link: 'http://team1/' } }, |
313 | { self: { self_link: 'http://team2/' } }] }; |
314 | - var data = module._get_unsubscribe_duplicates_text_and_subscriptions( |
315 | - args); |
316 | + module._get_unsubscribe_duplicates_text_and_subscriptions(args); |
317 | } |
318 | |
319 | })); |
320 | @@ -2457,8 +2456,7 @@ |
321 | var args = { bugs: [ { self: { self_link: 'http://bug/' } } ], |
322 | teams: [ { self: { self_link: 'http://team1/' } }, |
323 | { self: { self_link: 'http://team2/' } }] }; |
324 | - var data = module._get_unsubscribe_duplicates_text_and_subscriptions( |
325 | - args); |
326 | + module._get_unsubscribe_duplicates_text_and_subscriptions(args); |
327 | } |
328 | |
329 | })); |
330 | |
331 | === modified file 'lib/lp/registry/javascript/distroseries/widgets.js' |
332 | --- lib/lp/registry/javascript/distroseries/widgets.js 2013-04-09 05:05:39 +0000 |
333 | +++ lib/lp/registry/javascript/distroseries/widgets.js 2017-07-21 17:11:32 +0000 |
334 | @@ -434,7 +434,7 @@ |
335 | // of the parents is among them. |
336 | return true; |
337 | } |
338 | - var ds, choice; |
339 | + var ds; |
340 | for (ds in this._archindep_tags) { |
341 | var arch_tag = this._archindep_tags[ds]; |
342 | var i = 0; |
343 | |
344 | === modified file 'lib/lp/registry/javascript/distroseriesdifferences_details.js' |
345 | --- lib/lp/registry/javascript/distroseriesdifferences_details.js 2013-04-09 05:05:39 +0000 |
346 | +++ lib/lp/registry/javascript/distroseriesdifferences_details.js 2017-07-21 17:11:32 +0000 |
347 | @@ -106,7 +106,7 @@ |
348 | var blacklist_slot = container.one('div.blacklist-options'); |
349 | |
350 | if (blacklist_slot !== null) { |
351 | - var blacklist_widget = new BlacklistWidget( |
352 | + new BlacklistWidget( |
353 | {srcNode: blacklist_slot, |
354 | sourceName: source_name, |
355 | dsdLink: api_uri, |
356 | @@ -617,14 +617,14 @@ |
357 | |
358 | namespace.setup = function() { |
359 | Y.all('table.listing a.toggle-extra').each(function(toggle){ |
360 | - var row = new namespace.ExpandableRowWidget({toggle: toggle}); |
361 | + new namespace.ExpandableRowWidget({toggle: toggle}); |
362 | }); |
363 | }; |
364 | |
365 | var set_package_diff_status = function(container, new_status, note_msg) { |
366 | container.removeClass('request-derived-diff'); |
367 | container.removeClass('PENDING'); |
368 | - note = container.all('.note').remove(); |
369 | + container.all('.note').remove(); |
370 | container.addClass(new_status); |
371 | if (note_msg !== undefined) { |
372 | container.append([ |
373 | |
374 | === modified file 'lib/lp/registry/javascript/structural-subscription.js' |
375 | --- lib/lp/registry/javascript/structural-subscription.js 2017-07-21 17:11:31 +0000 |
376 | +++ lib/lp/registry/javascript/structural-subscription.js 2017-07-21 17:11:32 +0000 |
377 | @@ -885,7 +885,7 @@ |
378 | .set('text', LP.cache.context.title); |
379 | add_recipient_picker(content_node, hide_recipient_picker); |
380 | |
381 | - var accordion = create_accordion('#accordion-overlay', content_node); |
382 | + create_accordion('#accordion-overlay', content_node); |
383 | |
384 | // Set up click handlers for the events radio buttons. |
385 | var radio_group = Y.all('#events input'); |
386 | |
387 | === modified file 'lib/lp/registry/javascript/tests/test_distroseriesdifferences_details.js' |
388 | --- lib/lp/registry/javascript/tests/test_distroseriesdifferences_details.js 2017-07-21 17:11:31 +0000 |
389 | +++ lib/lp/registry/javascript/tests/test_distroseriesdifferences_details.js 2017-07-21 17:11:32 +0000 |
390 | @@ -95,7 +95,7 @@ |
391 | }, |
392 | |
393 | test_initializer: function() { |
394 | - var row = new module.ExpandableRowWidget({toggle: this.toggle}); |
395 | + new module.ExpandableRowWidget({toggle: this.toggle}); |
396 | Y.Assert.isTrue(this.toggle.hasClass('treeCollapsed')); |
397 | Y.Assert.isTrue(this.toggle.hasClass('sprite')); |
398 | }, |
399 | |
400 | === modified file 'lib/lp/registry/javascript/tests/test_team_mailinglists.js' |
401 | --- lib/lp/registry/javascript/tests/test_team_mailinglists.js 2017-07-21 17:11:31 +0000 |
402 | +++ lib/lp/registry/javascript/tests/test_team_mailinglists.js 2017-07-21 17:11:32 +0000 |
403 | @@ -54,8 +54,7 @@ |
404 | forwards_navigation: Y.all('.last,.next'), |
405 | backwards_navigation: Y.all('.first,.previous') |
406 | }; |
407 | - var message_list = new Y.lp.registry.team.mailinglists.MessageList( |
408 | - config); |
409 | + new Y.lp.registry.team.mailinglists.MessageList(config); |
410 | |
411 | var fired = false; |
412 | Y.on('messageList:backwards', function () { |
413 | |
414 | === modified file 'lib/lp/soyuz/javascript/base.js' |
415 | --- lib/lp/soyuz/javascript/base.js 2011-04-11 06:49:29 +0000 |
416 | +++ lib/lp/soyuz/javascript/base.js 2017-07-21 17:11:32 +0000 |
417 | @@ -23,7 +23,7 @@ |
418 | failure_message.addClass('update-failure-message'); |
419 | failure_message.one('span').set('text', text); |
420 | |
421 | - var retry_link = failure_message.one('a') |
422 | + failure_message.one('a') |
423 | .addClass('update-retry') |
424 | .set('href', '') |
425 | .on('click', handler); |
426 | |
427 | === modified file 'lib/lp/testing/tests/test_yuixhr_fixture.js' |
428 | --- lib/lp/testing/tests/test_yuixhr_fixture.js 2013-04-08 08:06:09 +0000 |
429 | +++ lib/lp/testing/tests/test_yuixhr_fixture.js 2017-07-21 17:11:32 +0000 |
430 | @@ -53,7 +53,7 @@ |
431 | }, |
432 | |
433 | test_teardown_clears_attributes: function() { |
434 | - var data = module.setup(this, 'baseline'); |
435 | + module.setup(this, 'baseline'); |
436 | module.teardown(this); |
437 | Y.Assert.isUndefined(this._lp_fixture_setups); |
438 | Y.Assert.isUndefined(this._lp_fixture_data); |