Merge lp:~cjwatson/launchpad/disable-pot-generation into lp:launchpad
Status: | Merged |
---|---|
Merged at revision: | 18453 |
Proposed branch: | lp:~cjwatson/launchpad/disable-pot-generation |
Merge into: | lp:launchpad |
Diff against target: |
64 lines (+5/-12) 3 files modified
Makefile (+5/-2) buildout.cfg (+0/-9) versions.cfg (+0/-1) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/disable-pot-generation |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+330157@code.launchpad.net |
Commit message
Disable launchpad.pot generation for now; it hasn't worked for some time, and obstructs converting the build system to pip.
Description of the change
Without modifications:
$ make potemplates
bin/i18nextra
make: bin/i18nextract.py: Command not found
Makefile:421: recipe for target 'launchpad.pot' failed
make: *** [launchpad.pot] Error 127
With the obvious fix:
$ make potemplates
bin/i18nextract
domain: 'launchpad'
configuration: /home/cjwatson/
exclude dirs: []
include default domain: True
python only: False
verify domain: False
header template: None
package: 'lp'
base: '/home/
path: '/home/
There was an error processing /home/cjwatson/
Traceback (most recent call last):
File "/home/
p.
File "/home/
self.
File "/home/
self.
File "/usr/lib/
self.
File "/usr/lib/
k = self.parse_
File "/usr/lib/
self.
File "/home/
self.
File "/home/
raise TALError("bad TAL attribute: " + `key`, position)
TALError: bad TAL attribute: 'xmlns:rdf', at line 1, column 1, in file /home/cjwatson/
Traceback (most recent call last):
File "bin/i18nextract", line 34, in <module>
'-p', 'lp'
File "/home/
maker.write()
File "/home/
entry.
File "/home/
file.
File "/home/
s = '"' + escape(s) + '"'
File "/home/
s[i] = escapes[ord(s[i])]
IndexError: list index out of range
Makefile:421: recipe for target 'launchpad.pot' failed
make: *** [launchpad.pot] Error 1
I didn't see an obvious fix for this at first glance, so let's remove this from the build system for the time being, since z3c.recipe.i18n requires buildout and that was going to require a moderate amount of reworking anyway in order to convert to pip. We can always add something similar back later if necessary.
what will we ever do