Merge lp:~cjwatson/launchpad/db-snap-build-channels into lp:launchpad/db-devel

Proposed by Colin Watson
Status: Merged
Merged at revision: 13808
Proposed branch: lp:~cjwatson/launchpad/db-snap-build-channels
Merge into: lp:launchpad/db-devel
Diff against target: 16 lines (+12/-0)
1 file modified
database/schema/patch-2209-83-1.sql (+12/-0)
To merge this branch: bzr merge lp:~cjwatson/launchpad/db-snap-build-channels
Reviewer Review Type Date Requested Status
William Grant db Approve
Review via email:

Commit message

Add Snap.auto_build_channels and SnapBuild.channels.

To post a comment you must log in.
Revision history for this message
William Grant (wgrant) wrote :

I'm not a fan of the unadorned "channels" name, as a build also has channels that it uploads to. But I can't think of an alternative that isn't horribly long.

review: Approve (db)
Revision history for this message
Colin Watson (cjwatson) wrote :

I could go with source_channels, but I think the current name fits with archive, distro_arch_series, and pocket. The "target" attributes are all Snap.store_*, so at least those ones are namespaced.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'database/schema/patch-2209-83-1.sql'
2--- database/schema/patch-2209-83-1.sql 1970-01-01 00:00:00 +0000
3+++ database/schema/patch-2209-83-1.sql 2018-02-08 13:39:59 +0000
4@@ -0,0 +1,12 @@
5+-- Copyright 2018 Canonical Ltd. This software is licensed under the
6+-- GNU Affero General Public License version 3 (see the file LICENSE).
8+SET client_min_messages=ERROR;
10+ALTER TABLE Snap ADD COLUMN auto_build_channels text;
11+ALTER TABLE SnapBuild ADD COLUMN channels text;
13+COMMENT ON COLUMN Snap.auto_build_channels IS 'A dictionary mapping snap names to channels to use when building this snap package.';
14+COMMENT ON COLUMN SnapBuild.channels IS 'A dictionary mapping snap names to channels to use for this build.';
16+INSERT INTO LaunchpadDatabaseRevision VALUES (2209, 83, 1);


People subscribed via source and target branches

to status/vote changes: