Merge lp:~cjwatson/launchpad/db-snap-allow-network into lp:launchpad/db-devel

[Colin Watson]

Add Snap.allow_internet.

See https://code.launchpad.net/~cjwatson/launchpad/snap-allow-network/+merge/336924 for the corresponding code change.

[William Grant (wgrant)]

I wonder if allow_internet or allow_proxy would be better. allow_network sounds rather more draconian than reality.

There are probably also few enough snaps that you could set the default and make the column NOT NULL here.

review: Approve (db)

=== added file 'database/schema/patch-2209-83-0.sql'
--- database/schema/patch-2209-83-0.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2209-83-0.sql	2018-04-04 12:33:50 +0000
@@ -0,0 +1,10 @@
+-- Copyright 2018 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+ALTER TABLE Snap ADD COLUMN allow_internet boolean DEFAULT true NOT NULL;
+
+COMMENT ON COLUMN Snap.allow_internet IS 'If True, builds of this snap may allow access to external network resources.';
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2209, 83, 0);