Launchpad itself

Merge lp:~cjwatson/launchpad/db-git-no-target-implies-owner into lp:launchpad/db-devel

  1. db-git-no-target-implies-owner
  2. Merge into db-devel
Proposed by Colin Watson on 2015-02-18
Status: Merged
Merged at revision: 12912
Proposed branch: lp:~cjwatson/launchpad/db-git-no-target-implies-owner
Merge into: lp:launchpad/db-devel
Diff against target: 12 lines (+8/-0)
1 file modified
database/schema/patch-2209-61-1.sql (+8/-0)
To merge this branch: bzr merge lp:~cjwatson/launchpad/db-git-no-target-implies-owner
Reviewer Review Type Date Requested Status
William Grant db 2015-02-18 Approve on 2015-02-18
Stuart Bishop db 2015-02-18 Pending
Review via email: mp+250114@code.launchpad.net

Commit Message

Drop GitRepository.target_implies_owner constraint.

Description of the Change

GitRepository.target_default implying GitRepository.owner_default has some difficult-to-resolve consequences for permissions, since the target owner might legitimately not be the repository owner and thus might not be able to set the owner-target default. We agreed in the Launchpad team meeting last night to remove this restriction, so we need to drop the constraint that enforces it.

To post a comment you must log in.
William Grant (wgrant) :
review: Approve (db)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'database/schema/patch-2209-61-1.sql'
2--- database/schema/patch-2209-61-1.sql 1970-01-01 00:00:00 +0000
3+++ database/schema/patch-2209-61-1.sql 2015-02-18 11:20:31 +0000
4@@ -0,0 +1,8 @@
5+-- Copyright 2015 Canonical Ltd. This software is licensed under the
6+-- GNU Affero General Public License version 3 (see the file LICENSE).
7+
8+SET client_min_messages=ERROR;
9+
10+ALTER TABLE GitRepository DROP CONSTRAINT target_implies_owner;
11+
12+INSERT INTO LaunchpadDatabaseRevision VALUES (2209, 61, 1);

Subscribers

People subscribed via source and target branches

to status/vote changes: