Merge lp:~cjwatson/launchpad/db-git-imports into lp:launchpad/db-devel

[Colin Watson]

Add GitRepository.repository_type, CodeImport.git_repository, and CodeImportJob.secret.

Add GitRepository.repository_type, CodeImport.git_repository, and CodeImportJob.secret.

[William Grant (wgrant)]

review: Approve (db)

[Colin Watson (cjwatson)]

My plan was to use macaroons (in this case mainly because that's a
conveniently-packaged version of HMAC, but it would fit well with other
future plans for HTTPS pushes), effectively generating a root key for
each job. But it would probably make more sense to have a single root
key configured using the slightly-awkward secret-management arrangements
in production-configs instead, and then attach the CodeImportJob.id as a
caveat in each case. I'll put together enough code to convince myself
that this will work and delete this column if so.

=== added file 'database/schema/patch-2209-80-0.sql'
--- database/schema/patch-2209-80-0.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2209-80-0.sql	2016-10-04 11:56:50 +0000
@@ -0,0 +1,27 @@
+-- Copyright 2016 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+ALTER TABLE GitRepository ADD COLUMN repository_type integer;
+
+COMMENT ON COLUMN GitRepository.repository_type IS 'Repositories are currently one of HOSTED (1) or IMPORTED (3).';
+
+ALTER TABLE CodeImport
+    ADD COLUMN git_repository integer REFERENCES gitrepository,
+    ALTER COLUMN branch DROP NOT NULL,
+    ADD CONSTRAINT one_target_vcs CHECK (
+        (branch IS NOT NULL) != (git_repository IS NOT NULL)),
+    ADD CONSTRAINT valid_source_target_vcs_pairing CHECK (
+        branch IS NOT NULL OR rcs_type = 4),
+    DROP CONSTRAINT codeimport_branch_key;
+
+COMMENT ON COLUMN CodeImport.branch IS 'The Bazaar branch produced by the import system, if applicable.  A placeholder branch is created when the import is created.  The import is associated with a target through the branch.';
+COMMENT ON COLUMN CodeImport.git_repository IS 'The Git repository produced by the import system, if applicable.  A placeholder repository is created when the import is created.  The import is associated with a target through the repository.';
+
+CREATE UNIQUE INDEX codeimport__branch__key
+    ON CodeImport(branch) WHERE branch IS NOT NULL;
+CREATE UNIQUE INDEX codeimport__git_repository__key
+    ON CodeImport(git_repository) WHERE git_repository IS NOT NULL;
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2209, 80, 0);