Merge lp:~cjwatson/launchpad/db-build-depends-arch into lp:launchpad/db-devel

Proposed by Colin Watson
Status: Rejected
Rejected by: Colin Watson
Proposed branch: lp:~cjwatson/launchpad/db-build-depends-arch
Merge into: lp:launchpad/db-devel
Diff against target: 16 lines (+12/-0)
1 file modified
database/schema/patch-2209-74-0.sql (+12/-0)
To merge this branch: bzr merge lp:~cjwatson/launchpad/db-build-depends-arch
Reviewer Review Type Date Requested Status
Colin Watson (community) Disapprove
Stuart Bishop db Pending
Launchpad code reviewers db Pending
Review via email: mp+282344@code.launchpad.net

Commit message

Add SourcePackageRelease.builddependsarch and SourcePackageRelease.build_conflicts_arch columns.

Description of the change

Add SourcePackageRelease.builddependsarch and SourcePackageRelease.build_conflicts_arch columns.

These aren't yet in policy, but have been in dpkg for a few years (https://bugs.debian.org/629480) without significant changes, and some packages (e.g. mplayer) have started to use them. I think they need explicit columns rather than using user_defined_fields because they ought to be displayed in the web UI alongside their siblings.

The spelling is peculiar, but I thought it was more important to stay consistent with the existing columns (builddepends, builddependsindep, build_conflicts, build_conflicts_indep).

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :
review: Disapprove

Unmerged revisions

13319. By Colin Watson

Add SourcePackageRelease.builddependsarch and SourcePackageRelease.build_conflicts_arch columns.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'database/schema/patch-2209-74-0.sql'
2--- database/schema/patch-2209-74-0.sql 1970-01-01 00:00:00 +0000
3+++ database/schema/patch-2209-74-0.sql 2016-01-12 17:04:22 +0000
4@@ -0,0 +1,12 @@
5+-- Copyright 2016 Canonical Ltd. This software is licensed under the
6+-- GNU Affero General Public License version 3 (see the file LICENSE).
7+
8+SET client_min_messages=ERROR;
9+
10+ALTER TABLE SourcePackageRelease ADD COLUMN builddependsarch text;
11+ALTER TABLE SourcePackageRelease ADD COLUMN build_conflicts_arch text;
12+
13+COMMENT ON COLUMN SourcePackageRelease.builddependsarch IS 'The architecture-dependent build-dependencies for this source package release.';
14+COMMENT ON COLUMN SourcePackageRelease.build_conflicts_arch IS 'The list of packages that will conflict with this source while building in architecture-dependent environments, as mentioned in the control file "Build-Conflicts-Arch:" field.';
15+
16+INSERT INTO LaunchpadDatabaseRevision VALUES (2209, 74, 0);

Subscribers

People subscribed via source and target branches

to status/vote changes: