Merge lp:~cjwatson/launchpad/copy-explicit-pocket into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Curtis Hovey |
Approved revision: | no longer in the source branch. |
Merged at revision: | 16183 |
Proposed branch: | lp:~cjwatson/launchpad/copy-explicit-pocket |
Merge into: | lp:launchpad |
Diff against target: |
352 lines (+130/-27) 6 files modified
lib/lp/soyuz/interfaces/archive.py (+12/-3) lib/lp/soyuz/interfaces/packagecopyjob.py (+19/-1) lib/lp/soyuz/model/archive.py (+14/-5) lib/lp/soyuz/model/packagecopyjob.py (+43/-18) lib/lp/soyuz/tests/test_archive.py (+26/-0) lib/lp/soyuz/tests/test_packagecopyjob.py (+16/-0) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/copy-explicit-pocket |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code | Approve | |
Review via email: mp+131002@code.launchpad.net |
Commit message
Allow specifying source distroseries and pocket in Archive.copyPackage and in PackageCopyJob metadata.
Description of the change
== Summary ==
Bug 1070324: Incremental copying of binaries doesn't work. Fixing this would save us a lot of (variously) manual recovery work and careful attention to avoid manual recovery work, particularly now that we're about to start automatically copying things from PROPOSED to RELEASE.
== Proposed fix ==
Allow optionally passing a source distroseries and pocket to Archive.
The underlying copy script workflow is tested in lib/lp/
== Implementation details ==
I moved PCJ's Archive.
== LOC Rationale ==
+103. I have 5754 lines of credit at the moment, and I think this is worth it to avoid occasional manual recovery work.
== Tests ==
bin/test -vvct lp.soyuz.
== Demo and Q/A ==
A lack of dogfood/staging builders makes it hard to QA anything involving real builds, never mind for multiple architectures; but given the tests and that this is a new optional facility it's probably reasonable to just check that copies without from_series/
Thank you.