Merge lp:~cjwatson/launchpad/configure-code-git-markup into lp:launchpad

Proposed by Colin Watson on 2016-04-28
Status: Merged
Merged at revision: 18011
Proposed branch: lp:~cjwatson/launchpad/configure-code-git-markup
Merge into: lp:launchpad
Diff against target: 18 lines (+5/-3)
1 file modified
lib/lp/code/templates/configure-code.pt (+5/-3)
To merge this branch: bzr merge lp:~cjwatson/launchpad/configure-code-git-markup
Reviewer Review Type Date Requested Status
William Grant code 2016-04-28 Approve on 2016-04-28
Review via email: mp+293190@code.launchpad.net

Commit message

Add missing table around git_repository_location widget row on Product:+configure-code, so that errors are highlighted properly.

Description of the change

Add missing table around git_repository_location widget row on Product:+configure-code, so that errors are highlighted properly.

To post a comment you must log in.
William Grant (wgrant) wrote :

Ew.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/code/templates/configure-code.pt'
2--- lib/lp/code/templates/configure-code.pt 2016-04-07 13:01:08 +0000
3+++ lib/lp/code/templates/configure-code.pt 2016-04-28 02:13:39 +0000
4@@ -141,9 +141,11 @@
5
6 <h3>Link an existing repository</h3>
7 <p>Link to an existing Git repository already on Launchpad</p>
8- <tal:widget define="widget nocall:view/widgets/git_repository_location">
9- <metal:block use-macro="context/@@launchpad_form/widget_row" />
10- </tal:widget>
11+ <table>
12+ <tal:widget define="widget nocall:view/widgets/git_repository_location">
13+ <metal:block use-macro="context/@@launchpad_form/widget_row" />
14+ </tal:widget>
15+ </table>
16 </div>
17 </div>
18 </div>