Merge lp:~cjwatson/launchpad/choose-icon into lp:launchpad
Proposed by
Colin Watson
Status: | Merged |
---|---|
Merged at revision: | 18437 |
Proposed branch: | lp:~cjwatson/launchpad/choose-icon |
Merge into: | lp:launchpad |
Diff against target: |
41 lines (+11/-8) 2 files modified
lib/lp/app/javascript/calendar.js (+5/-1) lib/lp/app/javascript/picker/picker_patcher.js (+6/-7) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/choose-icon |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | Approve | ||
Review via email: mp+327983@code.launchpad.net |
Commit message
Show a search icon for pickers where possible rather than "Choose...".
Description of the change
I always thought the green "Choose..." text looked rather ugly, and it gets particularly bad in a branch I'm working on where I have Git repository and branch input boxes displayed in a single row. Requesting a picker is essentially a search operation, or at least the start of one, so I think it makes sense to use the search icon here.
To post a comment you must log in.