Merge lp:~cjwatson/launchpad/buildmaster-getFile-rename into lp:launchpad
Proposed by
Colin Watson
Status: | Merged |
---|---|
Merged at revision: | 18543 |
Proposed branch: | lp:~cjwatson/launchpad/buildmaster-getFile-rename |
Merge into: | lp:launchpad |
Diff against target: |
32 lines (+7/-1) 1 file modified
lib/lp/buildmaster/interactor.py (+7/-1) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/buildmaster-getFile-rename |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+336709@code.launchpad.net |
Commit message
Write files fetched from builders to a temporary name, and only rename them into place on success.
Description of the change
This is a slightly speculative attempt to fix odd checksum mismatches on files fetched from builders for gcc-7-cross-ports builds: my theory is that a Deferred might be left over from a previous retry iteration and try to write to the same file. At any rate, it should be pretty safe to follow the rename-into-place protocol here.
To post a comment you must log in.