Merge lp:~cjwatson/launchpad/builders-visibility into lp:launchpad
Status: | Merged |
---|---|
Approved by: | William Grant |
Approved revision: | no longer in the source branch. |
Merged at revision: | 16679 |
Proposed branch: | lp:~cjwatson/launchpad/builders-visibility |
Merge into: | lp:launchpad |
Diff against target: |
67 lines (+36/-2) 2 files modified
lib/lp/app/browser/tales.py (+2/-1) lib/lp/app/tests/test_tales.py (+34/-1) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/builders-visibility |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+170818@code.launchpad.net |
Commit message
Render links to public builds in private archives owned by private teams as "private job".
Description of the change
== Summary ==
There are a couple of cases where builds can be otherwise public (copies of sources already published in public archives; recipe builds from public branches) but be for archives owned by private teams. This causes PackageBuildFor
This has been a long-standing problem, and at least two frequent causes are known, but as far as I can tell there is just one underlying cause. Note that the original traceback in bug 760303 was addressed by the fix for bug 728673, but the case of recipe builds from public branches in archives owned by private teams still remained.
== Proposed fix ==
Explicitly check visibility of the archive, and if that fails render the link to the build as "private job". It's close enough and much safer.
== LOC Rationale ==
+34
I think this is tolerable to address a frequent operational issue which causes a good deal of complaint on LP-related channels.
== Tests ==
bin/test -vvct lp.app.
== Demo and Q/A ==
Copy a public SPPH to a private archive owned by a private team on DF and set it building; check that /builders is still visible when logged out.