Merge lp:~cjwatson/launchpad/bpb-external-dependencies into lp:launchpad
Proposed by
Colin Watson
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 17881 | ||||
Proposed branch: | lp:~cjwatson/launchpad/bpb-external-dependencies | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
259 lines (+126/-9) 7 files modified
lib/lp/security.py (+19/-1) lib/lp/soyuz/configure.zcml (+6/-2) lib/lp/soyuz/interfaces/archive.py (+2/-2) lib/lp/soyuz/interfaces/binarypackagebuild.py (+21/-2) lib/lp/soyuz/model/binarypackagebuild.py (+17/-1) lib/lp/soyuz/stories/webservice/xx-builds.txt (+1/-0) lib/lp/soyuz/tests/test_binarypackagebuild.py (+60/-1) |
||||
To merge this branch: | bzr merge lp:~cjwatson/launchpad/bpb-external-dependencies | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+281744@code.launchpad.net |
Commit message
Allow PPA admins to set external_
Description of the change
Allow PPA admins to set external_
Using launchpad.Moderate is a little odd, but no other existing permission on that object was suitable, and this doesn't seem completely wrong. The alternatives that I can think of would be opening this facility up to buildd admins, or introducing a new role-based permission for PPA admins.
To post a comment you must log in.