Merge lp:~cjwatson/launchpad/basemailer-oops into lp:launchpad
Proposed by
Colin Watson
Status: | Merged |
---|---|
Merged at revision: | 17683 |
Proposed branch: | lp:~cjwatson/launchpad/basemailer-oops |
Merge into: | lp:launchpad |
Diff against target: |
98 lines (+30/-9) 2 files modified
lib/lp/services/mail/basemailer.py (+25/-9) lib/lp/services/mail/tests/test_basemailer.py (+5/-0) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/basemailer-oops |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+264856@code.launchpad.net |
Commit message
Improve OOPS logging when BaseMailer fails to send a message.
Description of the change
Improve OOPS logging when BaseMailer fails to send a message.
Future scripts using BaseMailer will need to pass in a request argument. At the moment, all uses of BaseMailer are in jobs or in the buildmaster, and I think in both those cases it's OK just to not bother passing in a request.
To post a comment you must log in.