Merge lp:~cjwatson/launchpad/authserver-macaroon into lp:launchpad
Proposed by
Colin Watson
Status: | Merged |
---|---|
Merged at revision: | 18725 |
Proposed branch: | lp:~cjwatson/launchpad/authserver-macaroon |
Merge into: | lp:launchpad |
Diff against target: |
197 lines (+123/-5) 3 files modified
lib/lp/services/authserver/interfaces.py (+12/-1) lib/lp/services/authserver/tests/test_authserver.py (+90/-2) lib/lp/services/authserver/xmlrpc.py (+21/-2) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/authserver-macaroon |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+345354@code.launchpad.net |
Commit message
Add an authserver endpoint to verify macaroons.
Description of the change
This is intended to support a reworking of https:/
"Returns True or a fault" is a bit of a weird interface, but there isn't really anything else to return, None is annoying in XML-RPC, and I think this is a bit more idiomatic for our XML-RPC endpoints than "returns True or False" would be.
To post a comment you must log in.