Merge lp:~cjwatson/launchpad/ampoule-0.2.0.post1 into lp:launchpad

Proposed by Colin Watson
Status: Merged
Merged at revision: 18460
Proposed branch: lp:~cjwatson/launchpad/ampoule-0.2.0.post1
Merge into: lp:launchpad
Diff against target: 15 lines (+4/-1)
1 file modified
versions.cfg (+4/-1)
To merge this branch: bzr merge lp:~cjwatson/launchpad/ampoule-0.2.0.post1
Reviewer Review Type Date Requested Status
William Grant code Approve
Review via email: mp+330862@code.launchpad.net

Commit message

Upgrade to ampoule 0.2.0.post1, with any luck fixing mysterious job-runner-related test failures.

Description of the change

The failures in question are (for example) http://lpbuildbot.canonical.com/builders/lp-devel-precise/builds/1588/steps/shell_9/logs/summary. I'm only guessing that this will solve them, since I can't reproduce them locally, but from the log output we have I'm at least reasonably sure that the problem is somewhere in ampoule, and this seems a likely suspect.

The forked ampoule branch is https://code.launchpad.net/~launchpad/ampoule/lp; the substantive changes in it are https://code.launchpad.net/~cjwatson/ampoule/process-error-not-ready/+merge/330848 and https://code.launchpad.net/~cjwatson/ampoule/fix-manifest/+merge/330857.

I'd prefer to version this as 0.2.0+lp1, per PEP 440's "Local version identifiers" scheme, but our pre-Cambrian version of setuptools doesn't like that; so I went for 0.2.0.post1 on the basis that old setuptools more or less tolerates it and it will sort properly under new setuptools once we upgrade.

To post a comment you must log in.
Revision history for this message
William Grant (wgrant) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'versions.cfg'
2--- versions.cfg 2017-09-13 11:12:39 +0000
3+++ versions.cfg 2017-09-15 19:57:33 +0000
4@@ -7,7 +7,10 @@
5 [versions]
6 # Alphabetical, case-insensitive, please! :-)
7
8-ampoule = 0.2.0
9+# lp:~launchpad/ampoule/lp
10+# post1 Don't add a process back to the ready set if it received an error
11+# such as a timeout.
12+ampoule = 0.2.0.post1
13 amqp = 1.4.9
14 amqplib = 1.0.2
15 anyjson = 0.3.3