Launchpad itself

Merge ~cjwatson/launchpad:charm-ppa-binary-wheels into launchpad:master

  1. Git
  2. lp:~cjwatson/launchpad
  3. charm-ppa-binary-wheels
  4. Merge into master
Proposed by Colin Watson
Status: Merged
Approved by: Ines Almeida
Approved revision: 8ccbbfb4fc8ec489d62d6d60b0f94399fb2f4132
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:charm-ppa-binary-wheels
Merge into: launchpad:master
Diff against target: 18 lines (+2/-0)
2 files modified
charm/launchpad-ppa-publisher/charmcraft.yaml (+1/-0)
charm/launchpad-ppa-uploader/charmcraft.yaml (+1/-0)
Reviewer Review Type Date Requested Status
Ines Almeida Approve
Review via email: mp+452116@code.launchpad.net

Commit message

charm: Build PPA publisher/uploader with binary wheels

Description of the change

This avoids needing things like `libpq-dev` to be installed before we can start executing charm code, and it matches all our other charms.

To post a comment you must log in.
Revision history for this message
Ines Almeida (ines-almeida) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charm/launchpad-ppa-publisher/charmcraft.yaml b/charm/launchpad-ppa-publisher/charmcraft.yaml
2index 76dc78c..13d0d15 100644
3--- a/charm/launchpad-ppa-publisher/charmcraft.yaml
4+++ b/charm/launchpad-ppa-publisher/charmcraft.yaml
5@@ -73,3 +73,4 @@ parts:
6 - CHARM_INTERFACES_DIR: $CRAFT_STAGE/layers/interface
7 - PIP_NO_INDEX: "true"
8 - PIP_FIND_LINKS: $CRAFT_STAGE/charm-wheels
9+ reactive-charm-build-arguments: [--binary-wheels-from-source]
10diff --git a/charm/launchpad-ppa-uploader/charmcraft.yaml b/charm/launchpad-ppa-uploader/charmcraft.yaml
11index 4ff69d8..392d3ad 100644
12--- a/charm/launchpad-ppa-uploader/charmcraft.yaml
13+++ b/charm/launchpad-ppa-uploader/charmcraft.yaml
14@@ -61,3 +61,4 @@ parts:
15 - CHARM_INTERFACES_DIR: $CRAFT_STAGE/layers/interface
16 - PIP_NO_INDEX: "true"
17 - PIP_FIND_LINKS: $CRAFT_STAGE/charm-wheels
18+ reactive-charm-build-arguments: [--binary-wheels-from-source]

Subscribers

People subscribed via source and target branches

to status/vote changes: