Merge ~cjwatson/launchpad:charm-enable-more-services into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 8a63646b1cec09c3e26f81b0f3c46f63e4beee97
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:charm-enable-more-services
Merge into: launchpad:master
Diff against target: 24 lines (+3/-1)
2 files modified
charm/launchpad-appserver/reactive/launchpad-appserver.py (+2/-1)
charm/launchpad-assets/reactive/launchpad-assets.py (+1/-0)
Reviewer Review Type Date Requested Status
Guruprasad Approve
Review via email: mp+448543@code.launchpad.net

Commit message

charm: Enable appserver and convoy services

Description of the change

The charms already (re)started these services, but didn't tell systemd to enable them, so they didn't start again after a reboot.

To post a comment you must log in.
Revision history for this message
Guruprasad (lgp171188) wrote :

LGTM 👍

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charm/launchpad-appserver/reactive/launchpad-appserver.py b/charm/launchpad-appserver/reactive/launchpad-appserver.py
2index de4d1d0..6179dc0 100644
3--- a/charm/launchpad-appserver/reactive/launchpad-appserver.py
4+++ b/charm/launchpad-appserver/reactive/launchpad-appserver.py
5@@ -147,7 +147,8 @@ def configure():
6 @when("coordinator.granted.restart")
7 def restart():
8 hookenv.log("Restarting application server")
9- host.service_restart("launchpad")
10+ host.service_restart("launchpad.service")
11+ host.service_resume("launchpad.service")
12 set_state("service.configured")
13
14
15diff --git a/charm/launchpad-assets/reactive/launchpad-assets.py b/charm/launchpad-assets/reactive/launchpad-assets.py
16index ee2b74e..50fe2f8 100644
17--- a/charm/launchpad-assets/reactive/launchpad-assets.py
18+++ b/charm/launchpad-assets/reactive/launchpad-assets.py
19@@ -107,6 +107,7 @@ def configure():
20 check=True,
21 )
22 configure_convoy(config)
23+ host.service_resume("convoy.socket")
24 set_flag("service.configured")
25
26

Subscribers

People subscribed via source and target branches

to status/vote changes: