Merge ~cjwatson/launchpad:fix-stormify-logintoken into launchpad:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | 9f738a66b8a762bd0fac4b7f6bb41636382db97c |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:fix-stormify-logintoken |
Merge into: | launchpad:master |
Diff against target: |
53 lines (+14/-10) 2 files modified
lib/lp/scripts/tests/test_garbo.py (+4/-2) lib/lp/services/verification/model/logintoken.py (+10/-8) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Colin Watson (community) | Approve | ||
Review via email: mp+446419@code.launchpad.net |
Commit message
Fix bugs in conversion of LoginToken to Storm
Description of the change
`LoginTokenSet.new` needs to explicitly add the new token to the store, as it may not be linked to any other object if it doesn't have a requester (e.g. `LoginTokenType
`test_LoginToke
To post a comment you must log in.
Self-approving this, as this is just some small and fairly clear fixes in code well-covered by the test suite.