Launchpad itself

Merge ~cjwatson/launchpad:core24 into launchpad:master

  1. Git
  2. lp:~cjwatson/launchpad
  3. core24
  4. Merge into master
Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: c3398dbb360726e100dedee69a7822658ad72061
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:core24
Merge into: launchpad:master
Diff against target: 13 lines (+1/-1)
1 file modified
lib/lp/services/fields/__init__.py (+1/-1)
Reviewer Review Type Date Requested Status
Simone Pelosi Approve
Review via email: mp+446153@code.launchpad.net

Commit message

Add core24 as a permitted core snap name

Description of the change

`core24` exists in the store now, though only in the edge channel, so this allows snap recipes that use it as a base to specify a channel for it. (This would presumably only be used for experimentation or for special cases, until this base is officially released.)

To post a comment you must log in.
Revision history for this message
Simone Pelosi (pelpsi) wrote :

LGTM!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/services/fields/__init__.py b/lib/lp/services/fields/__init__.py
2index 13bbc6c..a4a919a 100644
3--- a/lib/lp/services/fields/__init__.py
4+++ b/lib/lp/services/fields/__init__.py
5@@ -1012,7 +1012,7 @@ class InlineObject(Object):
6 class SnapBuildChannelsField(Dict):
7 """A field that holds source snap channels for builds."""
8
9- _core_snap_names = ["core", "core18", "core20", "core22"]
10+ _core_snap_names = ["core", "core18", "core20", "core22", "core24"]
11
12 def __init__(
13 self,

Subscribers

People subscribed via source and target branches

to status/vote changes: