Merge ~cjwatson/launchpad:snap-base-features-stale-comment into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: eb0200981b84720df576e47ad63cdff86700f5f6
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:snap-base-features-stale-comment
Merge into: launchpad:master
Diff against target: 15 lines (+0/-4)
1 file modified
lib/lp/snappy/adapters/buildarch.py (+0/-4)
Reviewer Review Type Date Requested Status
Ines Almeida Approve
Review via email: mp+445980@code.launchpad.net

Commit message

snappy: Remove stale XXX comment

To post a comment you must log in.
Revision history for this message
Ines Almeida (ines-almeida) wrote :

The lint build failed, but it seems like a random failure

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/snappy/adapters/buildarch.py b/lib/lp/snappy/adapters/buildarch.py
2index d2dc8fd..bd36747 100644
3--- a/lib/lp/snappy/adapters/buildarch.py
4+++ b/lib/lp/snappy/adapters/buildarch.py
5@@ -226,10 +226,6 @@ def determine_architectures_to_build(
6 # architecture; this is ambiguous and forbidden by snapcraft prior
7 # to core22. Checking this here means that we don't get duplicate
8 # supported_arch results below.
9-
10- # XXX andrey-fedoseev 2022-08-22: we should use the `SnapBase` model
11- # to store the specific features of each base rather than hard-coding
12- # the base names here
13 build_ons = Counter()
14 for arch in architectures:
15 build_ons.update(arch.build_on)

Subscribers

People subscribed via source and target branches

to status/vote changes: