Merge ~cjwatson/launchpad:charm-scripts-actions into launchpad:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | 7169f5d2a6c300e02bbd651044caf2cd49165769 |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:charm-scripts-actions |
Merge into: | launchpad:master |
Diff against target: |
116 lines (+82/-0) 5 files modified
charm/launchpad-scripts/README.md (+11/-0) charm/launchpad-scripts/actions.yaml (+9/-0) charm/launchpad-scripts/actions/actions.py (+60/-0) charm/launchpad-scripts/actions/start-services (+1/-0) charm/launchpad-scripts/actions/stop-services (+1/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Guruprasad | Approve | ||
Ines Almeida | Approve | ||
Review via email:
|
Commit message
charm/launchpad
Description of the change
In our legacy production deployment, we stop and start these services around certain kinds of maintenance actions, mainly database schema upgrades. The preferred way to do this sort of thing in Juju is using actions, so define a couple of suitable actions; once we deploy this to production, we'll set up an SSH trigger allowing developers to run any of an allowlist of actions on production.
To post a comment you must log in.
Makes sense to me
Added a small question in the comments. action_ set()`? In the docs it seems to be the value that the action returns - but we don't seem to use any return value from the actions (?). Is it mostly because as action needs to return something?
Also what's the purpose of `hookenv.