Merge ~cjwatson/launchpad:fix-make-schema-in-charmed-deployment into launchpad:master
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | 4b5fe2a49cbd998ae456de42a66fba6422df5362 |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:fix-make-schema-in-charmed-deployment |
Merge into: | launchpad:master |
Diff against target: |
19 lines (+3/-5) 1 file modified
database/schema/Makefile (+3/-5) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ines Almeida | Approve | ||
Review via email: mp+444933@code.launchpad.net |
Commit message
Fix database initialization in charmed deployments
Description of the change
In charmed deployments, `launchpad-admin` is typically related to `postgresql`, which causes the `postgresql` charm to automatically create an empty `session_dev` database. This confuses the `create` target in `database/
I couldn't find any record in git history of why we bother to perform this check for `session_dev` when we don't do so for any of the other databases. I think it makes more sense to assume that if you're running the `create` target then you mean to actually create all the databases, so this commit brings the handling of `session_dev` into line with all the other databases.
LGTM!
Happy to see this issue going away! :D