Launchpad itself

Merge ~cjwatson/launchpad:charm-librarian-worker-count-change into launchpad:master

  1. Git
  2. lp:~cjwatson/launchpad
  3. charm-librarian-worker-count-change
  4. Merge into master
Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 173008248c9a257e5e2a2cf8b8e5ffb9895cb9a1
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:charm-librarian-worker-count-change
Merge into: launchpad:master
Diff against target: 12 lines (+1/-0)
1 file modified
charm/launchpad-librarian/reactive/launchpad-librarian.py (+1/-0)
Reviewer Review Type Date Requested Status
Ines Almeida Approve
Review via email: mp+444201@code.launchpad.net

Commit message

charm/launchpad-librarian: Restart when worker count is changed

Description of the change

If the `workers` config option is changed in isolation, then none of the files currently checked for changes by the `configure` hook are changed, so it fails to restart the service to start up the new workers. Avoid this problem by adding `/lib/systemd/system-generators/launchpad-librarian-generator` to the list of monitored files.

To post a comment you must log in.
Revision history for this message
Ines Almeida (ines-almeida) wrote :

Makes sense

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charm/launchpad-librarian/reactive/launchpad-librarian.py b/charm/launchpad-librarian/reactive/launchpad-librarian.py
2index 67cc398..2fe4630 100644
3--- a/charm/launchpad-librarian/reactive/launchpad-librarian.py
4+++ b/charm/launchpad-librarian/reactive/launchpad-librarian.py
5@@ -129,6 +129,7 @@ def configure():
6 base.version_info_path(),
7 "/lib/systemd/system/launchpad-librarian.service",
8 "/lib/systemd/system/launchpad-librarian@.service",
9+ "/lib/systemd/system-generators/launchpad-librarian-generator",
10 ]
11 + config_files()
12 ):

Subscribers

People subscribed via source and target branches

to status/vote changes: