Merge ~cjwatson/launchpad:charm-assets-favicon into launchpad:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | 79c203685b218f8c30e54e7d7d758d4f49573c46 |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:charm-assets-favicon |
Merge into: | launchpad:master |
Diff against target: |
15 lines (+6/-0) 1 file modified
charm/launchpad-assets/templates/vhost.conf.j2 (+6/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Guruprasad | Approve | ||
Review via email: mp+444125@code.launchpad.net |
Commit message
charm: Serve favicons from assets charm
Description of the change
This allows us to serve these files from the frontends without hitting the appservers. I'm not sure why we serve `lib/canonical/
I think in practice most browsers will prefer the icons declared in HTML via `lib/lp/
To post a comment you must log in.
LGTM 👍