Merge ~cjwatson/launchpad:charm-librarian-doc-migration-wording into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 920d90f07dfe123c6731e908fdd8d1a9625d8de3
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:charm-librarian-doc-migration-wording
Merge into: launchpad:master
Diff against target: 22 lines (+5/-6)
1 file modified
charm/launchpad-librarian/README.md (+5/-6)
Reviewer Review Type Date Requested Status
Jürgen Gmach Approve
Review via email: mp+442972@code.launchpad.net

Commit message

charm: Tidy up wording for librarian's active=false mode

Description of the change

Responding to a review comment in https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/442615. I don't really want to describe this as a read-only mode with exceptions, but perhaps this is clearer.

To post a comment you must log in.
Revision history for this message
Jürgen Gmach (jugmac00) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charm/launchpad-librarian/README.md b/charm/launchpad-librarian/README.md
2index bd2a657..52ab88c 100644
3--- a/charm/launchpad-librarian/README.md
4+++ b/charm/launchpad-librarian/README.md
5@@ -30,12 +30,11 @@ Only one instance of the librarian may be active at any one time, and very
6 little downtime is acceptable on production. This means that we have to be
7 especially careful when redeploying. The general procedure is as follows:
8
9-1. Deploy a new unit with `active=false`. This will run the librarian in
10- more or less a read-only mode: downloads are possible, and cron jobs that
11- would modify the database, the contents of the librarian, or the contents
12- of Swift are disabled. If uploads happen they will be spooled locally,
13- but that's low-risk since only Launchpad itself uploads to the librarian.
14- This allows testing connectivity.
15+1. Deploy a new unit with `active=false`. This will disable periodic jobs
16+ that would modify the database, the contents of the librarian, or the
17+ contents of Swift. Downloads are possible, and if uploads happen they
18+ will be spooled locally, but that's low-risk since only Launchpad itself
19+ uploads to the librarian. This mode allows testing connectivity.
20
21 1. Ensure that a Ceph volume is mounted persistently on
22 `/srv/launchpad/librarian/`. On production this should be a 2 TiB volume

Subscribers

People subscribed via source and target branches

to status/vote changes: