Merge ~cjwatson/launchpad:unexport-getBuildSummariesForSnapBuildIds into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 44e845d15f7dc6cc6dedd6d684d7f42b83c62c9d
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:unexport-getBuildSummariesForSnapBuildIds
Merge into: launchpad:master
Diff against target: 20 lines (+0/-10)
1 file modified
lib/lp/snappy/interfaces/snap.py (+0/-10)
Reviewer Review Type Date Requested Status
Jürgen Gmach Approve
Review via email: mp+442912@code.launchpad.net

Commit message

Unexport Snap.getBuildSummariesForSnapBuildIds

Description of the change

In https://code.launchpad.net/~cjwatson/launchpad/snap-request-builds-ui/+merge/348299, I wrote "Deprecated as an exported method; can become an internal helper method once production JavaScript no longer uses it" above `Snap.getBuildSummariesForSnapBuildIds` ... and then promptly forgot about it for nearly five years. Finish this off.

To post a comment you must log in.
Revision history for this message
Jürgen Gmach (jugmac00) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/snappy/interfaces/snap.py b/lib/lp/snappy/interfaces/snap.py
2index fe9b768..f8e6505 100644
3--- a/lib/lp/snappy/interfaces/snap.py
4+++ b/lib/lp/snappy/interfaces/snap.py
5@@ -597,16 +597,6 @@ class ISnapView(Interface):
6 )
7 )
8
9- # XXX cjwatson 2018-06-20: Deprecated as an exported method; can become
10- # an internal helper method once production JavaScript no longer uses
11- # it.
12- @operation_parameters(
13- snap_build_ids=List(
14- title=_("A list of snap build IDs."), value_type=Int()
15- )
16- )
17- @export_read_operation()
18- @operation_for_version("devel")
19 def getBuildSummariesForSnapBuildIds(snap_build_ids):
20 """Return a dictionary containing a summary of the build statuses.
21

Subscribers

People subscribed via source and target branches

to status/vote changes: