Launchpad itself

Merge ~cjwatson/launchpad:remove-packages-arch-specific-comments into launchpad:master

  1. Git
  2. lp:~cjwatson/launchpad
  3. remove-packages-arch-specific-comments
  4. Merge into master
Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 54cc609b400f8f5f15703456db8ba4f846e94125
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:remove-packages-arch-specific-comments
Merge into: launchpad:master
Diff against target: 27 lines (+0/-5)
2 files modified
lib/lp/soyuz/interfaces/publishing.py (+0/-4)
lib/lp/soyuz/scripts/packagecopier.py (+0/-1)
Reviewer Review Type Date Requested Status
Jürgen Gmach Approve
Review via email: mp+442871@code.launchpad.net

Commit message

Remove obsolete comments about Packages-arch-specific

Description of the change

"Packages-arch-specific", or "P-a-s", was an old system used to prevent certain packages from building on certain architectures. As of commit a375e857d75f2572f9125517847607739a6cc985 in 2013 we no longer support this, so we can drop a few old comments about it that no longer make any sense.

To post a comment you must log in.
Revision history for this message
Jürgen Gmach (jugmac00) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/soyuz/interfaces/publishing.py b/lib/lp/soyuz/interfaces/publishing.py
2index 5b861a8..600f089 100644
3--- a/lib/lp/soyuz/interfaces/publishing.py
4+++ b/lib/lp/soyuz/interfaces/publishing.py
5@@ -557,10 +557,6 @@ class ISourcePackagePublishingHistoryPublic(IPublishingView):
6 def createMissingBuilds(architectures_available=None, logger=None):
7 """Create missing Build records for a published source.
8
9- P-a-s should be used when accepting sources to the PRIMARY archive
10- (in drescher). It explicitly ignores given P-a-s for sources
11- targeted to PPAs.
12-
13 :param architectures_available: options list of `DistroArchSeries`
14 that should be considered for build creation; if not given
15 it will be calculated in place, all architectures for the
16diff --git a/lib/lp/soyuz/scripts/packagecopier.py b/lib/lp/soyuz/scripts/packagecopier.py
17index 8b62816..2e1557d 100644
18--- a/lib/lp/soyuz/scripts/packagecopier.py
19+++ b/lib/lp/soyuz/scripts/packagecopier.py
20@@ -911,7 +911,6 @@ def _do_direct_copy(
21
22 # Always ensure the needed builds exist in the copy destination
23 # after copying the binaries.
24- # XXX cjwatson 2012-06-22 bug=869308: Fails to honour P-a-s.
25 source_copy.createMissingBuilds(logger=logger)
26
27 if move:

Subscribers

People subscribed via source and target branches

to status/vote changes: