Merge ~cjwatson/launchpad:loggerhead-fix-robots into launchpad:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | 318b67fbdbd6ae17d9eea1725e471bcd10a94f2a |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad:loggerhead-fix-robots |
Merge into: | launchpad:master |
Diff against target: |
31 lines (+8/-1) 2 files modified
lib/launchpad_loggerhead/app.py (+1/-1) lib/launchpad_loggerhead/tests.py (+7/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ines Almeida | Approve | ||
Review via email: mp+442782@code.launchpad.net |
Commit message
launchpad_
Description of the change
On Python 3, the response to a request for `robots.txt` needs to be bytes or Gunicorn rejects it.
We didn't notice this on production or staging because this file is served via an Apache `Alias` directive rather than going via the appserver, but fixing it seems to make sense anyway.
To post a comment you must log in.
LGTM