Merge ~cjwatson/launchpad:charm-librarian-fixes into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 85af63ceb3bcc3ff0c4f84d77a3e396bee71a83a
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:charm-librarian-fixes
Merge into: launchpad:master
Diff against target: 37 lines (+7/-3)
2 files modified
charm/launchpad-librarian/reactive/launchpad-librarian.py (+6/-0)
charm/launchpad-librarian/templates/logrotate.conf.j2 (+1/-3)
Reviewer Review Type Date Requested Status
Simone Pelosi Approve
Review via email: mp+442048@code.launchpad.net

Commit message

charm: Fix a couple of bugs preventing the librarian from working

To post a comment you must log in.
Revision history for this message
Simone Pelosi (pelpsi) wrote :

LGTM!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charm/launchpad-librarian/reactive/launchpad-librarian.py b/charm/launchpad-librarian/reactive/launchpad-librarian.py
2index 6b4dda7..349f22a 100644
3--- a/charm/launchpad-librarian/reactive/launchpad-librarian.py
4+++ b/charm/launchpad-librarian/reactive/launchpad-librarian.py
5@@ -39,6 +39,12 @@ def configure_systemd(config):
6 "/lib/systemd/system/launchpad-librarian@.service",
7 config,
8 )
9+ templating.render(
10+ "launchpad-librarian-generator.j2",
11+ "/lib/systemd/system-generators/launchpad-librarian-generator",
12+ config,
13+ perms=0o555,
14+ )
15 subprocess.run(["systemctl", "daemon-reload"])
16
17
18diff --git a/charm/launchpad-librarian/templates/logrotate.conf.j2 b/charm/launchpad-librarian/templates/logrotate.conf.j2
19index 66e2b12..42c1d4d 100644
20--- a/charm/launchpad-librarian/templates/logrotate.conf.j2
21+++ b/charm/launchpad-librarian/templates/logrotate.conf.j2
22@@ -7,8 +7,7 @@
23 compress
24 notifempty
25 missingok
26- create 0644 syslog adm
27- sharedscripts
28+ create 0644 launchpad launchpad
29 postrotate
30 systemctl reload launchpad-librarian.service
31 endscript
32@@ -23,6 +22,5 @@
33 compress
34 notifempty
35 missingok
36- create 0644 syslog adm
37 }
38

Subscribers

People subscribed via source and target branches

to status/vote changes: